node-wit icon indicating copy to clipboard operation
node-wit copied to clipboard

enable proxy if https_proxy taken by env

Open muddydixon opened this issue 8 years ago • 10 comments

Abstract

enable proxy if https_proxy taken by env.

muddydixon avatar May 20 '16 11:05 muddydixon

I would have expected node-fetch to handle it directly (like request does).

Anyway, can you handle the following env vars:

  • HTTP_PROXY / http_proxy
  • HTTPS_PROXY / https_proxy
  • NO_PROXY / no_proxy

Thanks!

patapizza avatar Jun 01 '16 16:06 patapizza

i see, i'll try it.

muddydixon avatar Jun 14 '16 07:06 muddydixon

got it. please check it

muddydixon avatar Jun 14 '16 07:06 muddydixon

thx, fixed it

muddydixon avatar Nov 18 '16 02:11 muddydixon

Is there any progress on this? We need proxy support and would really like to use the official package.

patrick246 avatar Mar 20 '17 13:03 patrick246

I fixed it above commit. you check it? Or adjust master ?

muddydixon avatar Mar 22 '17 07:03 muddydixon

I wanted to know when this will be merged into master. Currently I have reimplemented muddydixon's solution in my own repository and we're using that, as the merge conflicts were too big to merge easily. For the future it would be nice if the official module supported this. My fork is currently on top of of master so it could be merged easily.

patrick246 avatar Mar 24 '17 10:03 patrick246

Hi, I found this issue as I need to use this package behind an HTTP proxy too. I'd be very keen on this PR being merged - @muddydixon, would you be able to rebase to fix conflicts so it can be merged? Currently I'm trying to work around this issue by using iptables to intercept requests to Wit's API which isn't ideal!

ultrafez avatar Oct 18 '17 16:10 ultrafez

I think I'm not the only one interested by this, but I don't feel like I have the knowledge to finish the rebase of this branch. Can this fix for handling proxies be merged now ? What is missing ?

JeSuisUnCaillou avatar Apr 12 '18 13:04 JeSuisUnCaillou

I'll surface this back with the team to see if we can prioritize it.

patapizza avatar May 25 '18 19:05 patapizza