node-wit
node-wit copied to clipboard
enable proxy if https_proxy taken by env
Abstract
enable proxy if https_proxy taken by env.
I would have expected node-fetch
to handle it directly (like request
does).
Anyway, can you handle the following env vars:
- HTTP_PROXY / http_proxy
- HTTPS_PROXY / https_proxy
- NO_PROXY / no_proxy
Thanks!
i see, i'll try it.
got it. please check it
thx, fixed it
Is there any progress on this? We need proxy support and would really like to use the official package.
I fixed it above commit. you check it? Or adjust master ?
I wanted to know when this will be merged into master. Currently I have reimplemented muddydixon's solution in my own repository and we're using that, as the merge conflicts were too big to merge easily. For the future it would be nice if the official module supported this. My fork is currently on top of of master so it could be merged easily.
Hi, I found this issue as I need to use this package behind an HTTP proxy too. I'd be very keen on this PR being merged - @muddydixon, would you be able to rebase to fix conflicts so it can be merged? Currently I'm trying to work around this issue by using iptables to intercept requests to Wit's API which isn't ideal!
I think I'm not the only one interested by this, but I don't feel like I have the knowledge to finish the rebase of this branch. Can this fix for handling proxies be merged now ? What is missing ?
I'll surface this back with the team to see if we can prioritize it.