Benedikt

Results 165 comments of Benedikt

> I had the feeling that returning an error was more confusing, because right now *data* is returned by hooks that do return data, not errors. Raising an exception makes...

It's unfortunate that this has gone stale; but as explained above at length, I'm not sold on using an `Exception` to communicate plugin decisions here, it seems like the wrong...

Looks the same or at least very similar to #4283. This might suggest that there's some issue with the logic behind our merge logic. Maybe there's an issue with the...

Thanks for delving deeper into this issue! Your analysis sounds a lot like the hunch that I had. > It's a little tricky to think of the right solution for...

Sounds like a reasonable improvement --- I guess beets is generally not very good at gracefully handling errors. In many cases, that's probably for the better, since an appropriate action...

Actually, the best thing to do would probably to check for all relevant files to exist before starting to move an object (album or item, depending on the command), and...

Hi @snejus, looking great! I have essentially no time to review this (or anything for beets) at the moment, so it will take me some time to get around to...

For now, I've only looked at the `lslimit` changes. It's great to get rid of the brittle implementation in the `HeadQuery` and use SQL `LIMIT` instead, we should absolutely do...

Alright, sorry for the long silence, but I'll have a little more time in the next weeks :) --- > Let me know if you want to know the specifics...

A semi-related issue is https://github.com/beetbox/beets/issues/750