owo-lib icon indicating copy to clipboard operation
owo-lib copied to clipboard
verified publisher icon wisp-forest

add support for multiple owo-ui windows

Open BasiqueEvangelist opened this issue 2 years ago • 8 comments

Adds support for opening windows from the main Minecraft window through the OwoWindow class ~~(and the more bare bones FramebufferWindow class).~~

Changes

  • ~~FramebufferWindow allows creating a low-level separate window, with rendering fully managed by the user~~
  • OwoWindow creates a window with an owo-ui component as the root, managing events and registering itself itself
  • WindowContext/CurrentWindowContext allow detecting the current window and registering per-window features (which is useful for UI components that create window-sized framebuffers or screens)

BasiqueEvangelist avatar Aug 04 '23 14:08 BasiqueEvangelist

on 1.20.2 now

BasiqueEvangelist avatar Oct 04 '23 20:10 BasiqueEvangelist

Why was this closed?

Minenash avatar Oct 22 '23 00:10 Minenash

Why was this closed?

I didn't want to continue maintaining a PR that didn't get any feedback after 1 month

BasiqueEvangelist avatar Oct 22 '23 11:10 BasiqueEvangelist

Yeah, that's fair. But damn, been looking forward to it since it was mentioned you were working on it

Minenash avatar Oct 22 '23 14:10 Minenash

Yeah, that's fair. But damn, been looking forward to it since it was mentioned you were working on it

I can try to extract it into a separate library if you want to play around with it. I will have to mixin into owo for that to work, though.

BasiqueEvangelist avatar Oct 22 '23 15:10 BasiqueEvangelist

Also, like, if there's any indication that this will be actually looked at (so that I won't have to bump the PR 6 times) I'll reopen this PR

BasiqueEvangelist avatar Oct 22 '23 15:10 BasiqueEvangelist

Yeah, if owo doesn't end up having it, then that would be awesome :heart:

Minenash avatar Oct 22 '23 15:10 Minenash

fuck it

BasiqueEvangelist avatar Oct 24 '23 20:10 BasiqueEvangelist