Freeze when using Yung's Better Ocean Monuments

[Mirsario]

This is kind of a reopen of #80 (Cartographer level-up freezes servers), but after both of the suggestions from there failed to help me I found one actual cause that isn't "it takes a long time" or vanilla's fault.

The cause of the freeze for me turned out to be the fact that cartographers were trying to locate the vanilla minecraft:monument structures, which Yung's Better Ocean Monuments removes from generation and replaces with the betteroceanmonuments:ocean_monument structure. If I were to make a guess, it's probably due to Numismatic Overhaul changing the trade type to its own special numismatic-overhaul:sell_map, so the generation mod doesn't recognize it to swap the vanilla structure type to its new one? Though I couldn't find the code for that, so I don't know for sure which side is at fault.

Pinging @yungnickyoung just in case.

Temporary Workaround

Applying the following change in NurismaticOverhaul.jar/data/nurismatic-overhaul/villager_trades/cartographer.json helped me avoid the issue for myself:

      {
        "type": "numismatic-overhaul:sell_map",
        "price": 3000,
-        "structure": "monument",
+        "structure": "betteroceanmonuments:ocean_monument",
        "max_uses": 2,
        "villager_experience": 15
      }

Crash Report

If you want to look at my colossal collection of mixins, which I don't think matters, here it is: crash-2023-07-07_00.09.06-server.txt