google-search-fixer icon indicating copy to clipboard operation
google-search-fixer copied to clipboard

Causes browser to freeze when interacting with images in Google search

Open kubrickfr opened this issue 1 year ago • 10 comments

As it has been reported many times on the add-on home page recently, whether it's something Google did or Mozilla, using this add-on makes Firefox "freeze" when tapping on images in Google search.

kubrickfr avatar Jul 17 '23 16:07 kubrickfr

I was able to reproduce this last week:

  1. Install the add-on, allow access to private browsing.
  2. Search for "Smiley"
  3. Tap on the image in the search regular results. Result: Google Search result page seems to freeze.

Additionally, I verified that the "freeze" is not a deadlock in Firefox or something. It looks like the Google Search result page itself intentionally refuses to scroll down.

Rob--W avatar Jul 17 '23 18:07 Rob--W

Someone also filed a bug with some details at https://bugzilla.mozilla.org/show_bug.cgi?id=1843106

Rob--W avatar Jul 17 '23 18:07 Rob--W

This happens because the Google Search page for mobile versions of Chrome (and Safari) does not work properly in Firefox. To be precise, the preview window that appears after tapping an image is transparent in Firefox, which makes the search page look as if it is frozen. This problem also occurs when User-Agent is spoofed by other methods than this add-on in all versions of Firefox including PC version. It is unclear whether this is due to a bug in Firefox that prevents normal execution or whether Google's implementation deviates from the web standard and cannot be executed in Gecko. In any case, it is necessary to implement a script in the add-on to modify the preview window so that it can be displayed correctly.

tesmite avatar Jul 21 '23 07:07 tesmite

One notable thing is that on Firefox there's aria-hidden=true on <c-wiz> but not on Chrome. Perhaps something fails to un-hide or such?

Edit: Another is that #Sva75c .dFMRD gets an inline style="opacity: 0; pointer-events: none;" only on Firefox. Edit 2: dFMRD also gets aria-busy=true on Firefox but =false on Chrome. One may guess some rendering process failed in the middle of something.

saschanaz avatar Jul 21 '23 11:07 saschanaz

I think this is at least partially Firefox bug.

  1. Click an image in https://www.google.com/search?q=%EC%9F%88%EB%9D%BC+%EB%AF%B8%EB%82%98%EC%BD%94
  2. Find .dFMRD (there's only one)
  3. Remove opacity: 0 (At this point still nothing is visible.)
  4. Try removing every attribute and children of that element and add some text node, so that it effectively becomes just <div>Foo</div>. Still nothing is visible
  5. Try editing that node with "Edit As HTML". Suddenly the element becomes visible

So the element just mysteriously gets stuck with invisible state that I cannot explain in CSS way.

saschanaz avatar Jul 21 '23 12:07 saschanaz

Reopened https://bugzilla.mozilla.org/show_bug.cgi?id=1843106.

saschanaz avatar Jul 21 '23 12:07 saschanaz

Love and appreciate the add-on since the start of using Firefox.

I'm having the same issue and several people in the extension's Mozilla Add-ons review section are reporting it as well. It seems it's gotten worse the last few months. Any news on a possible fix? The alternative of not using it is extremely user-unfriendly, as users know.. Google pushes the worst version of their search experience to Firefox users. It's frustrating having to turn the extension on and off several times a day -- refreshing doesn't work anymore, it's totally broken, both in the initial Google search results page & in the Google Images page.

It says the add-on hasn't been updated since Oct. 6th, 2020, so at first I wasn't sure if this was still being actively maintained (or needed regular updates). I'm sure a lot of Firefox users use this extension so I'm surprised it's apparently not affecting even more people cause they would've said something!

PigDan20 avatar Aug 03 '23 17:08 PigDan20

shame Noone found the root cause yet. Is there any way I could help? Is anyone acfively working on this?

Djfe avatar Sep 08 '23 12:09 Djfe

oh, wait. it appears this got fixed somehow, maybe by Google?

Djfe avatar Sep 08 '23 12:09 Djfe

As commented at https://bugzilla.mozilla.org/show_bug.cgi?id=1843106#c30, I am still able to reproduce in some cases.

Rob--W avatar Sep 08 '23 12:09 Rob--W