wishthis
Translations sync and usage - Shared list shows English language
First off: thank you for this great wishlist project!
Noticed a challenge when trying to share a Wishlist in another language (Dutch). The supporting text kept showing the following English text:
If you found a wish you would like to fulfill, open the wish and then click the button and it will be unavailable for everybody else.
Then I found issue 172 and read about missing translations. So I fired up Transifex and finished the Dutch translations (from 97% to 100%). FYI: the text mentioned above, was already translated.
My Profile - Preferences - Language is set to Nederlands and the Channel is set to Release Candidate, assuming this will get updates earlier to aid with testing.
I created the wishlist, when the language was set to English. Sharing that worked like a charm (tested in a private browser window). When I changed my language to Dutch and shared the same wishlist, the shared wishlist was suddenly empty (showing no wishes).
Assuming non-automatic translation syncs, I hereby request a sync for the Dutch language (NL).
Hey @sebastianschauenburg,
thank you for your detailed report!
When I changed my language to Dutch and shared the same wishlist, the shared wishlist was suddenly empty (showing no wishes).
The selected language shouldn't affect any of the functionality. Could you check if there is an error in your browser's development console?
Assuming non-automatic translation syncs, I hereby request a sync for the Dutch language (NL).
The translations do need to be merged manually, which I have now done for the release-candidate branch. Can you please let me know if everything is working as expected?
@grandeljay Thanks for the quick reply and consideration.
Had a bit of time today and quickly started testing with my alternate browser (Chromium) in a Private window. I found out something, peculiar.
When opening the 'public' list, the language on the page remains English (top banner). The list also appears to be empty . I do notice these 2 errors in the developer console:
semantic.min.js?v=46543eb9:11 API: API action used but no url was defined get wishes by wishlist hash {}
error @ semantic.min.js?v=46543eb9:11
templatedURL @ semantic.min.js?v=46543eb9:11
query @ semantic.min.js?v=46543eb9:11
invoke @ semantic.min.js?v=46543eb9:11
(anonymous) @ semantic.min.js?v=46543eb9:11
each @ jquery.min.js?v=b76ee5d0:2
each @ jquery.min.js?v=b76ee5d0:2
O.fn.api @ semantic.min.js?v=46543eb9:11
(anonymous) @ wishlist-filter-priority.js?v=004a5dc9:64
dispatch @ jquery.min.js?v=b76ee5d0:2
v.handle @ jquery.min.js?v=b76ee5d0:2
trigger @ jquery.min.js?v=b76ee5d0:2
(anonymous) @ jquery.min.js?v=b76ee5d0:2
each @ jquery.min.js?v=b76ee5d0:2
each @ jquery.min.js?v=b76ee5d0:2
trigger @ jquery.min.js?v=b76ee5d0:2
(anonymous) @ wishlist-filter-priority.js?v=004a5dc9:73
e @ jquery.min.js?v=b76ee5d0:2
t @ jquery.min.js?v=b76ee5d0:2
setTimeout
(anonymous) @ jquery.min.js?v=b76ee5d0:2
c @ jquery.min.js?v=b76ee5d0:2
fireWith @ jquery.min.js?v=b76ee5d0:2
fire @ jquery.min.js?v=b76ee5d0:2
c @ jquery.min.js?v=b76ee5d0:2
fireWith @ jquery.min.js?v=b76ee5d0:2
ready @ jquery.min.js?v=b76ee5d0:2
setTimeout
(anonymous) @ jquery.min.js?v=b76ee5d0:2
(anonymous) @ jquery.min.js?v=b76ee5d0:2
(anonymous) @ jquery.min.js?v=b76ee5d0:2
and
semantic.min.js?v=46543eb9:11 API: No URL specified for api event
query @ semantic.min.js?v=46543eb9:11
invoke @ semantic.min.js?v=46543eb9:11
(anonymous) @ semantic.min.js?v=46543eb9:11
each @ jquery.min.js?v=b76ee5d0:2
each @ jquery.min.js?v=b76ee5d0:2
O.fn.api @ semantic.min.js?v=46543eb9:11
(anonymous) @ wishlist-filter-priority.js?v=004a5dc9:64
dispatch @ jquery.min.js?v=b76ee5d0:2
v.handle @ jquery.min.js?v=b76ee5d0:2
trigger @ jquery.min.js?v=b76ee5d0:2
(anonymous) @ jquery.min.js?v=b76ee5d0:2
each @ jquery.min.js?v=b76ee5d0:2
each @ jquery.min.js?v=b76ee5d0:2
trigger @ jquery.min.js?v=b76ee5d0:2
(anonymous) @ wishlist-filter-priority.js?v=004a5dc9:73
e @ jquery.min.js?v=b76ee5d0:2
t @ jquery.min.js?v=b76ee5d0:2
setTimeout
(anonymous) @ jquery.min.js?v=b76ee5d0:2
c @ jquery.min.js?v=b76ee5d0:2
fireWith @ jquery.min.js?v=b76ee5d0:2
fire @ jquery.min.js?v=b76ee5d0:2
c @ jquery.min.js?v=b76ee5d0:2
fireWith @ jquery.min.js?v=b76ee5d0:2
ready @ jquery.min.js?v=b76ee5d0:2
setTimeout
(anonymous) @ jquery.min.js?v=b76ee5d0:2
(anonymous) @ jquery.min.js?v=b76ee5d0:2
(anonymous) @ jquery.min.js?v=b76ee5d0:2
When changing the "Preferred languages" in the Settings of the browser and adding "Dutch", suddenly the errors disappeared and the list appeared. Removing the language from the browser settings, made the list disappear again*.
*) Unfortunately, when I switched to Firefox it suddenly worked correctly and afterwards (in Chrome) it worked also, even without explicitly having Dutch added. Did not get consistent results, will have to try again at a later date (but wanted to let you know already). The banner "What to do?" seems to remain in English in the Incognito window though, but in my logged in session, it is correctly visible in Dutch 😄
When opening the 'public' list, the language on the page remains English (top banner). The list also appears to be empty .
Are you using the wishthis.online instance? I was able to get the public link to show Dutch translations using a locale switcher extension for firefox
I do notice these 2 errors in the developer console:
I was unfortunately not able to reproduce this behaviour :/
When changing the "Preferred languages" in the Settings of the browser and adding "Dutch", suddenly the errors disappeared and the list appeared. Removing the language from the browser settings, made the list disappear again*.
Same here. I removed all preferred languages in m browser but there still was no JS error on the public wishlist page for me