generative-models icon indicating copy to clipboard operation
generative-models copied to clipboard

query about ALI_BIGAN

Open devraj89 opened this issue 6 years ago • 1 comments

Hi Thanks for your wonderful code! I was looking through the code for Bidirectional GAN and have a few doubts : [1] In the discriminator step why is Line 83 required ? Is it required to update the generator during discriminator learning ? should not it be fixed ? Is this a G_solver.step() needed ?

[2] while updating the generator(Q and P), are you using the the inverse objective function found in Appendix 2 page 16 here at https://arxiv.org/pdf/1605.09782.pdf ? otherwise should not it be a minimization problem and the - sign in Line 93 not required ?

[3] also why is the final layer in the generator a sigmoid layer ?

Thanks in advance ! I will be grateful to hear anything on this matter.

devraj89 avatar Jun 13 '18 03:06 devraj89

Hi,

I used ALI paper (https://arxiv.org/pdf/1606.00704.pdf) as reference for this code. You might want to check Algorithm 1 in page 3 there.

Cheers

wiseodd avatar Jun 15 '18 07:06 wiseodd