wise-old-man icon indicating copy to clipboard operation
wise-old-man copied to clipboard

Published 20 hours ago • verified publisher icon wise-old-man

Add combined EHP hiscores

Open autumn-smellegy opened this issue 1 year ago • 8 comments

Add an option on the EHP hiscores to show all accounts combined. The hiscores could look something like this:

  1. Ironman_beast: 20,000 EHP
  2. f2p_ironman_dork: 18,000 EHP
  3. uim_gamer: 15,000 EHP
  4. 200m_all_normie: 12,814 EHP
  5. rank1_lvl3: 11,788 ehp

Filters should still be able to be applied so that, for example, you could look at all F2P accounts and include ironmen and lvl3 ironmen.

Example of this feature on temple: https://templeosrs.com/virtualhiscores/time_played_combined.php?

autumn-smellegy avatar Sep 20 '23 19:09 autumn-smellegy

Does this mean rank by EHP regardless of their type/build?

psikoi avatar Sep 21 '23 07:09 psikoi

Yes exactly @psikoi

autumn-smellegy avatar Sep 28 '23 18:09 autumn-smellegy

Would this require changes to the api? Or it can be achieved on the front-end only?

devenini avatar Oct 02 '23 23:10 devenini

Right now if you do /efficiency/leaderboard?metric=ehp (no filters) the API will use type=regular and build=main by default, which won't allow for this "no filters" sort of leaderboard.

I believe the changes would be:

  • Change the API to not apply those defaults ^
  • Change app-v2 and app-v2 to have the type pre-selected to "regular" and build pre-selected to "build"
    • So that they request /efficiency/leaderboard?metric=ehp&type=regular&build=main by default
  • Add "Any build" and "Any type" options to the dropdowns, that would essentially request /efficiency/leaderboard?metric=ehp

Sounds a bit confusing, let me know if it's clear

psikoi avatar Oct 02 '23 23:10 psikoi

How to you see this in the UI? Something like this?

Screenshot_14

Or this?

Screenshot_13

devenini avatar Oct 02 '23 23:10 devenini

First one I'd say, and the link to that page would have to have the "default" filters baked into the url, so that "combined" wouldn't be the default

psikoi avatar Oct 02 '23 23:10 psikoi

Essentially these filters would now be the same as the current top/records leaderboards, expect with some pre-selections on the UI

psikoi avatar Oct 02 '23 23:10 psikoi

Would be nice if the combined hiscore also allow us to combine specific builds. E.g. from a multiselect I could select the build "F2P" and "F2P Level 3". The API would need to support a query like this /efficiency/leaderboard?metric=ehp&type=ironman&build=f2p&build=f2p_lvl3

Default values would be "Any build" and "Any type"

devenini avatar Oct 24 '23 12:10 devenini