[Bug] Loops on connectors number vs list index issue

[ryane67]

When using loops on connectors, the check to draw ensures the connector number is in the list, however when they are drawn, the connection between the points is made from what appears to be the list index and not by the pin number.

connectors:
  AP-DISCO:
    pins: [1]
    pinlabels: [GND_SW]
  APRS1-J281:
    pins: [0,1,2,3,4,5,8,9,10,11,12,13,14,15]
    pinlabels: [SHELL, CANHI, CANLO,CANTERM1, CANTERM2,IDSTRAP_1,IDSTRAP_4,PWRGND, ACFTPWR,TRIMIN1, TRIMIN2, TRIMOUT1, TRIMOUT2, APDISCO]
    <<: [*db15_m, *can_device]
    loops:
      - [4,5]
      - [5,8]

The intent here would be to realistically use 3,4 and 5,8 as the loops however I used 4,5 when testing whether it would use the index of pins in the list to create the graph.

[kvid]

Thank you for reporting this unfortunate bug with the current loops implementation. It's heavily related to #432 that is already marked with a TODO in the code.