WireViz icon indicating copy to clipboard operation
WireViz copied to clipboard

Complete PDF output handler

Open tobiasfalk opened this issue 1 year ago • 3 comments

Everything was already prepaired, and I just had to make some minor changes. I do not know why this was prepaired but not finished.

tobiasfalk avatar May 29 '24 08:05 tobiasfalk

@martinrieder yes and no, Yes it does not add frames and so. And No since I originally just wanted a PDF output and was not interested in the frame, since PDF is just a robuster vector graphics format and is less dependent on the interpreter.

tobiasfalk avatar Jun 14 '24 23:06 tobiasfalk

Maybe we need to make some destinguishment through another CLI argument that would request BOM output, templates and metadata to be included, which is currently only supported for HTML.

EDIT: Alternatively, the list of output formats for the -f CLI switch might be extended to contain PDF either with or without BOM. See the PR on CLI here:

  • #244

martinrieder avatar Jun 15 '24 09:06 martinrieder

@martinrieder wrote:

Maybe we need to make some destinguishment through another CLI argument that would request BOM output, templates and metadata to be included, which is currently only supported for HTML.

EDIT: Alternatively, the list of output formats for the -f CLI switch might be extended to contain PDF either with or without BOM.

If you want to include a BOM in the diagram (as in #227) and optionally also a frame, then such extra elements will be added to all graphical output types, and controlling this by different output type specifiers makes no sense to me. A common specifyer for what to include in the diagram is then needed, and the HTML output should be adjusted accordingly to avoid doubled BOM and frame.

kvid avatar Oct 06 '24 18:10 kvid