WireViz icon indicating copy to clipboard operation
WireViz copied to clipboard

[bug] Bundles to have consistent part number fields

Open Tyler-Ward opened this issue 5 years ago • 2 comments

Splitting out of https://github.com/formatc1702/WireViz/pull/115#discussion_r508000264

Curently in a bundle the part number fields will be rendered differently if they are a string or a list. If they are a string they are rendered at the top of a node and if a list they are rendered per wire, it mould make sense for this to be consistent across bundles by always doing the latter.

Tyler-Ward avatar Oct 20 '20 21:10 Tyler-Ward

AFAIK, this is by design. Attributes common to all wires are listed above all wires (except image, and notes below all wires), and attributes specified for each wire are listed above and below each wire. Currently, both options are implemented for pn, manufacturer, and mpn, but it has been discussed to support the same for gauge too.

kvid avatar Oct 20 '20 22:10 kvid

AFAIK, this is by design.

Correct. Here's the history:

  • At the beginning, the only parameter that could change on a per-wire basis, was color. Everything else (type, length, gauge, ...) was global for the entire cable, thus displayed above the wires.
  • Currently, bundles implement separate [manufacturer] part number parameters.
  • In the future (see #56), more parameters might be editable on a per-wire basis.

That's why, IMHO, we shouldn't see this as a bug, nor worry about it too much, because I think some major refactoring may be in order to cleanly implement the transition for more granularity.

17o2 avatar Oct 21 '20 06:10 17o2