Refactor and write test for `Strings#findLongestLineLength` method.

Open nstdio opened this issue 4 years ago • 1 comments

Oct 17 '21 13:10 nstdio

How about writing a test for wrapIfLongestLineExceedsLimit rather than having to make findLongestLineLength visible?

Oct 20 '21 15:10 tomakehurst

Hey, @oleg-nenashev! Thanks for your thoughts. My intent was very modest: write it in a more expressive way. Frankly, I'm not particularly interested in merging this after couple of years, especially when old version does the job very well :slightly_smiling_face:

Aug 06 '23 10:08 nstdio

@nstdio yeah, fair point. I joined the co-maintainers in July, so it takes some time to clear the backlog of PRs. Indeed it's weird to ask after 2 years, but it does not hurt. If you're fine with that, I will merge in the tests part.

Aug 06 '23 11:08 oleg-nenashev