helm-charts
helm-charts copied to clipboard
podAnnotations is incorrectly passed to deployment
Proposal
Add removal of all leading and trailing whitespace, including newlines via {{- -}} here https://github.com/wiremock/helm-charts/blob/master/charts/wiremock/templates/_helpers.tpl#L71 and parse with toYaml
{{- toYaml .Values.podAnnotations | nindent 0 -}}
othewise the tenplate is not rendered when podAnnotation is provided
Reproduction steps
add
podAnnotations:
aa: bb
to values.yaml, fire
❯ helm template .
Error: YAML parse error on wiremock/templates/deployment.yaml: error converting YAML to JSON: yaml: line 23: could not find expected ':'
Use --debug flag to render out invalid YAML
References
No response
Hi! I have a same issue :(
Fixed by https://github.com/wiremock/helm-charts/pull/60