wiredash-sdk icon indicating copy to clipboard operation
wiredash-sdk copied to clipboard

Make WiredashController.show asynchronous

Open Nokiater opened this issue 1 year ago • 0 comments

Is your feature request related to a problem? Please describe.

  1. When a user finished providing feedback after he submitted it, I would like to perform some follow-up actions. (P.e. to request an in-app review after user submitted feedback.) I don't think this is currently possible because the underlying WiredashModel.show() function is async while the exposed ModelController.show() wrapper function is not.

  2. In addition to this, it would also be useful to have access to the submitted data. P.e. I would like to enhance user-experience by persisting/caching the (optional) email-adress the user provided so I can prefill the email-adress in subsequent feedback message submissions

Describe the solution you'd like The 1st enhancement is very easy. Since the underlying model's show() method is already async, this would involve changing just 1 line of code.

The additional enhancement would return the entered user-data in the return value.

Describe alternatives you've considered I was unable to find any workaround to provide these desired features. I considered implementing my custom Controller by extending the WiredashController to override the show() method but as the underlying model is private, this doesn't seem to provide any solution.

Additional context n/a

Nokiater avatar Aug 25 '23 13:08 Nokiater