wire-webapp
wire-webapp copied to clipboard
fix: remove binding teams references
fix and avoid an issue with a deprecated endpoint GET /teams
Prepares for the removal of non-binding teams by the BE.
Non-binding teams were the concept that a user may have multiple teams. In this case, they would not be bound to any team. In practice, users only have one team and the /teams endpoint always returns an array of 1 object. The only case this does not work is in the self-user case where they do not have a team.
The feature was not used except in this login case, and it is not necessary so it is being removed.
PR Submission Checklist for internal contributors
-
The PR Title
- [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [ ] contains a reference JIRA issue number like
SQPIT-764
- [ ] answers the question: If merged, this PR will: ... ³
-
The PR Description
- [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
- [ ] GitHub link to other pull request
Testing
Test Coverage (Optional)
- [ ] I have added automated test to this contribution
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
- [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue
PR Post Merge Checklist for internal contributors
- [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
- https://sparkbox.com/foundry/semantic_commit_messages
- https://github.com/wireapp/.github#usage
- E.g.
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.
Codecov Report
Merging #13456 (8390fdc) into dev (6481d4c) will decrease coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #13456 +/- ##
==========================================
- Coverage 39.10% 39.07% -0.03%
==========================================
Files 566 567 +1
Lines 20969 21020 +51
Branches 4513 4530 +17
==========================================
+ Hits 8199 8214 +15
- Misses 11792 11829 +37
+ Partials 978 977 -1