wire-webapp
wire-webapp copied to clipboard
chore(csp): cleanup default CSP values (SQCORE-527)
|
PR Submission Checklist for internal contributors
-
The PR Title
- [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [x] contains a reference JIRA issue number like
SQPIT-764
- [x] answers the question: If merged, this PR will: ... ³
-
The PR Description
- [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability
What's new in this PR?
Issues
The default CSP configuration contains several unnecessary entries, probably required in previous releases.
Solutions
Remove all CSP entries, that are no longer required.
Testing
How to Test
These changes should not break anything, but if they do they should be observervable by automated CI tests. Potentially affected:
- initial account creation (profile picture creation)
- display of profile pictures
- youtube/soundcloud/spotify/vimeo integration
PR Post Submission Checklist for internal contributors (Optional)
- [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue
PR Post Merge Checklist for internal contributors
- [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
- https://sparkbox.com/foundry/semantic_commit_messages
- https://github.com/wireapp/.github#usage
- E.g.
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.
Codecov Report
Merging #13427 (5a093b4) into dev (94c91c2) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## dev #13427 +/- ##
=======================================
Coverage 39.08% 39.08%
=======================================
Files 568 568
Lines 21042 21042
Branches 4544 4544
=======================================
Hits 8225 8225
Misses 11834 11834
Partials 983 983