wire-webapp icon indicating copy to clipboard operation
wire-webapp copied to clipboard

feat: Improve eslint toolkit with missing plugins / rules

Open aweiss-dev opened this issue 2 years ago • 1 comments

What's new in this PR?

Issues

Right now, eslint doesn't include rules for imports, import-order, react-hooks, prettier, and some more. Some of it is quality of life improvements like common code formatting, and common import order rules (autofix). Some of it I would say, is critical, like the missing eslint-plugin-react-hooks.

Solutions

  1. Add missing plugins and rules
  2. Autofix as much as possible
  3. Fix the rest of the errors manually

Needs releases with:

  • [ ] GitHub link to other pull request

Testing

How to Test

Eslint needs to run without an error.


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

aweiss-dev avatar Jul 14 '22 09:07 aweiss-dev

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@53177d1). Click here to learn what that means. The diff coverage is 40.80%.

@@          Coverage Diff           @@
##             dev   #13340   +/-   ##
======================================
  Coverage       ?   39.01%           
======================================
  Files          ?      558           
  Lines          ?    20743           
  Branches       ?     4395           
======================================
  Hits           ?     8092           
  Misses         ?    11693           
  Partials       ?      958           

codecov[bot] avatar Jul 14 '22 09:07 codecov[bot]

superseeded by #13806

atomrc avatar Oct 11 '22 12:10 atomrc