feat: Migrate Legal Hold Modal to React (ACC-197)
|
|
PR Submission Checklist for internal contributors
-
The PR Title
- [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [ ] contains a reference JIRA issue number like
SQPIT-764 - [ ] answers the question: If merged, this PR will: ... ³
-
The PR Description
- [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
- [ ] GitHub link to other pull request
Testing
Test Coverage (Optional)
- [ ] I have added automated test to this contribution
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
- [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue
PR Post Merge Checklist for internal contributors
- [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
- https://sparkbox.com/foundry/semantic_commit_messages
- https://github.com/wireapp/.github#usage
- E.g.
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.
Codecov Report
Merging #13313 (2160ec9) into acc (f218cef) will increase coverage by
0.22%. The diff coverage is27.50%.
@@ Coverage Diff @@
## acc #13313 +/- ##
==========================================
+ Coverage 40.95% 41.18% +0.22%
==========================================
Files 601 600 -1
Lines 21046 21021 -25
Branches 4739 4745 +6
==========================================
+ Hits 8620 8657 +37
+ Misses 11344 11277 -67
- Partials 1082 1087 +5
Can the LegalHoldViewModel be deleted?
Nah, it's used also in ew legal-hold-dot
@przemvs Let's try our best to completely remove the legalHoldModalViewModel. This should be possible by
- creating a small API to trigger the modal (using the
renderModalhelper that we created) - using this api to show the modal with the right param (like state and userId if needed)
- remove all calls to
amplify
Now we are dealing with 2 implementation of the legalhold modal, would be good to go all the way and migrate all the calls to the modal :)
@przemvs Let's try our best to completely remove the
legalHoldModalViewModel. This should be possible by
- creating a small API to trigger the modal (using the
renderModalhelper that we created)- using this api to show the modal with the right param (like state and userId if needed)
- remove all calls to
amplifyNow we are dealing with 2 implementation of the legalhold modal, would be good to go all the way and migrate all the calls to the modal :)
I think the best idea to wait for merge all stuff from '