wire-webapp icon indicating copy to clipboard operation
wire-webapp copied to clipboard

feat: Migrate Legal Hold Modal to React (ACC-197)

Open przemvs opened this issue 3 years ago • 4 comments

TaskACC-197 Migrate legal-hold-modal to React Component


PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • [ ] GitHub link to other pull request

Testing

Test Coverage (Optional)

  • [ ] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

przemvs avatar Jul 07 '22 09:07 przemvs

Codecov Report

Merging #13313 (2160ec9) into acc (f218cef) will increase coverage by 0.22%. The diff coverage is 27.50%.

@@            Coverage Diff             @@
##              acc   #13313      +/-   ##
==========================================
+ Coverage   40.95%   41.18%   +0.22%     
==========================================
  Files         601      600       -1     
  Lines       21046    21021      -25     
  Branches     4739     4745       +6     
==========================================
+ Hits         8620     8657      +37     
+ Misses      11344    11277      -67     
- Partials     1082     1087       +5     

codecov[bot] avatar Jul 07 '22 09:07 codecov[bot]

Can the LegalHoldViewModel be deleted?

Nah, it's used also in ew legal-hold-dot

przemvs avatar Jul 08 '22 05:07 przemvs

@przemvs Let's try our best to completely remove the legalHoldModalViewModel. This should be possible by

  • creating a small API to trigger the modal (using the renderModal helper that we created)
  • using this api to show the modal with the right param (like state and userId if needed)
  • remove all calls to amplify

Now we are dealing with 2 implementation of the legalhold modal, would be good to go all the way and migrate all the calls to the modal :)

atomrc avatar Jul 08 '22 09:07 atomrc

@przemvs Let's try our best to completely remove the legalHoldModalViewModel. This should be possible by

  • creating a small API to trigger the modal (using the renderModal helper that we created)
  • using this api to show the modal with the right param (like state and userId if needed)
  • remove all calls to amplify

Now we are dealing with 2 implementation of the legalhold modal, would be good to go all the way and migrate all the calls to the modal :)

I think the best idea to wait for merge all stuff from '

', and then finish the LegalHoldModal, because we will create context for repositories, and then use it everywhere. Now we need to pass from parent > children > children, etc...

przemvs avatar Aug 22 '22 12:08 przemvs