wire-webapp icon indicating copy to clipboard operation
wire-webapp copied to clipboard

refactor: remove last guests and services mapping

Open tlebon opened this issue 2 years ago • 1 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • [ ] GitHub link to other pull request

Testing

Test Coverage (Optional)

  • [ ] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

tlebon avatar Jun 27 '22 09:06 tlebon

Codecov Report

Merging #13259 (10535c6) into dev (cc6e47b) will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev   #13259      +/-   ##
==========================================
- Coverage   39.20%   39.18%   -0.03%     
==========================================
  Files         565      565              
  Lines       20943    20911      -32     
  Branches     4480     4478       -2     
==========================================
- Hits         8211     8193      -18     
+ Misses      11757    11743      -14     
  Partials      975      975              

codecov[bot] avatar Jun 27 '22 10:06 codecov[bot]