wire-server icon indicating copy to clipboard operation
wire-server copied to clipboard

Fix bug: clients without prekeys are not deleted competely

Open stefanwire opened this issue 3 years ago • 0 comments

https://wearezeta.atlassian.net/browse/FS-966

This PR changes the behaviour when clients without prekeys are detected during prekey claiming.

Without this PR: a client without any prekeys is deleted from other services synchronously, but not from brig. With this PR: a client without any prekeys is deleted

  1. synchronously from brig: This leads to the client not be listed anymore. Without this change the client's prekeys are attempted to be fetched over and over again also triggering the deletion attempts over and over again.
  2. asynchronously from all other services: This should improve response times when claming prekeys. The removal of clients from the galley service can be particularly slow for MLS clients. with this change it won't block prekey claiming

Checklist

  • [ ] Add a new entry in an appropriate subdirectory of changelog.d
  • [x] Read and follow the PR guidelines

stefanwire avatar Oct 07 '22 14:10 stefanwire