wire-server
wire-server copied to clipboard
Use New ConversationId for MLS Welcome Message
https://wearezeta.atlassian.net/browse/FS-532
Checklist
- [x] The PR Title explains the impact of the change.
- [x] The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
- [ ] changelog.d contains the following bits of information (details):
- [ ] A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside
changelog.d
.
- [ ] A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside
@pcapriotti Could you give this a look over to see if I'm even on the right track?
The client posts its Welcome messages in the context of a specific qualified conversation ID. (This would require an endpoint change.)
-- https://wearezeta.atlassian.net/wiki/spaces/~377173175/pages/605291411/Backend+MLS+Encrypted+Commit+and+Proposal+handling
Should I roll that endpoint change into this effort FS-532 ? @rohan-wire
It seems like that would address some of the defaulting issues in my resolveMember, since I'd have the conversation id "in hand".
@pcapriotti Could you give this a look over to see if I'm even on the right track?
Yes, it all seems correct, from what I can see. I guess you're mostly missing integration tests.
The client posts its Welcome messages in the context of a specific qualified conversation ID. (This would require an endpoint change.)
-- https://wearezeta.atlassian.net/wiki/spaces/~377173175/pages/605291411/Backend+MLS+Encrypted+Commit+and+Proposal+handling
Should I roll that endpoint change into this effort FS-532 ? @rohan-wire
It seems like that would address some of the defaulting issues in my resolveMember, since I'd have the conversation id "in hand".
That proposal is outdated. Please keep referring to https://wearezeta.atlassian.net/wiki/spaces/CORE/pages/553418860/MLS+implementation+in+wire-server, I've been trying to keep it up to date with the outcome of recent discussions. That endpoint change was discussed some time ago, but AFAIK we haven't reached a consensus.
That proposal is outdated.
I updated the outdated document rather radically. Please let me know @pcapriotti or @rohan-wire if I should change it back, or change it differently.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.