wire-server-deploy icon indicating copy to clipboard operation
wire-server-deploy copied to clipboard

Published 20 hours ago • verified publisher icon wireapp

Add kvmhelpers

Open julialongtin opened this issue 2 years ago • 5 comments

PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³

  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • [ ] GitHub link to other pull request

Testing

Test Coverage (Optional)

  • [ ] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

julialongtin avatar Aug 26 '22 12:08 julialongtin

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 26 '22 13:08 CLAassistant

The rebase:

Screenshot from 2022-09-12 11-16-05

Screenshot from 2022-09-12 11-16-13

Followed this guide to the letter. It resulted in a PR that was pretty much identical, but I think this makes sense considering nothing much has happened in WSD since this PR was created.

arthurwolf avatar Sep 12 '22 09:09 arthurwolf

I think some of the new scripts would benefit from having shellcheck passed over them.

stephen-smith avatar Sep 13 '22 01:09 stephen-smith

I think some of the new scripts would benefit from having shellcheck passed over them.

We have a bunch of comments from the linter at https://github.com/wireapp/wire-server-deploy/actions/runs/3036030802/jobs/4886865162 and I'm going through all of them, fixing what I can figure out how to fix, should be a bunch of commits coming in soon. Does shellcheck do something simiral?

arthurwolf avatar Sep 13 '22 09:09 arthurwolf

I think some of the new scripts would benefit from having shellcheck passed over them.

We have a bunch of comments from the linter and I'm going through all of them. Does shellcheck do something simiral?

At least some of those diagnostics are from ShellCheck. You can see the links to the ShellCheck wiki at the bottom on the linter report.

stephen-smith avatar Sep 13 '22 21:09 stephen-smith