wire-server-deploy icon indicating copy to clipboard operation
wire-server-deploy copied to clipboard

Bump ansible, kubespray

Open flokli opened this issue 2 years ago • 6 comments

This bumps ansible to the latest supported version in nixpkgs (2.12)

We still need to check https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_4.html and all our playbooks, if any need changes.

flokli avatar May 10 '22 08:05 flokli

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 08 '22 15:06 CLAassistant

So, it seems the error from CI:

fatal: [upward-hare-restund-1]: FAILED! => {"after": ["3B4FE6ACC0B21F32", "D94AA3F0EFE21092", "871920D1991BC93C"], "before": ["3B4FE6ACC0B21F32", "D94AA3F0EFE21092", "871920D1991BC93C"], "changed": true, "fp": "FD591E349AA74E75", "id": "FD591E349AA74E75", "key_id": "FD591E349AA74E75", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and not a subkey)", "short_id": "9AA74E75"}

Did hide the fact apt-key was failing on actually expired keys (and we use a key stored in GH Actions, not create an ephemeral one).

The key got renewed, and the comments around that updated, let's check CI again.

flokli avatar Jun 13 '22 16:06 flokli

Now CI is sucessfully bootstrapping the cluster, but failing here:


TASK [kubernetes-apps/ansible : Kubernetes Apps | Register coredns deployment annotation `createdby`] ***
skipping: [known-dogfish-kubenode-1]
skipping: [known-dogfish-kubenode-2]
fatal: [known-dogfish-kubenode-0]: FAILED! => {"changed": false, "cmd": "/usr/local/bin/kubectl get deploy -n kube-system coredns -o jsonpath='{ .spec.template.metadata.annotations.createdby }'", "delta": "0:00:00.142188", "end": "2022-06-13 17:45:58.007179", "msg": "non-zero return code", "rc": 1, "start": "2022-06-13 17:45:57.864991", "stderr": "Error from server (NotFound): deployments.apps \"coredns\" not found", "stderr_lines": ["Error from server (NotFound): deployments.apps \"coredns\" not found"], "stdout": "", "stdout_lines": []}
...ignoring
TASK [kubernetes-apps/ansible : Kubernetes Apps | Delete kubeadm CoreDNS] ******
skipping: [known-dogfish-kubenode-1]
skipping: [known-dogfish-kubenode-2]
ok: [known-dogfish-kubenode-0]
TASK [kubernetes-apps/ansible : Kubernetes Apps | Delete kubeadm Kube-DNS service] ***
skipping: [known-dogfish-kubenode-1]
skipping: [known-dogfish-kubenode-2]
ok: [known-dogfish-kubenode-0]
ERROR! 'item' is undefined

I'm not entirely sure why deployments.apps "coredns" can't be found. I'm suspecting that's fixed by https://github.com/kubernetes-sigs/kubespray/pull/8565/commits/685c284e26def2c683d1da035716dd9c22d51a0e, so I'll try cherry-picking that in.

flokli avatar Jun 13 '22 18:06 flokli

Cherry-picking various kubespray commits is not gonna fly.

We need to update kubespray (and update our offline bundle to include the updated dependencies of kubespray).

flokli avatar Jun 14 '22 11:06 flokli

I updated this PR to just bump kubespray to the latest release, (and use git submodule again).

flokli avatar Jun 14 '22 16:06 flokli

This needs to be rebased, and once https://github.com/wireapp/wire-server-deploy/pull/583 is merged, the revert of it added to this PR.

flokli avatar Aug 31 '22 14:08 flokli

This has been heavily superceeded, thankfully. closing.

julialongtin avatar Apr 19 '24 13:04 julialongtin