wire-ios_legacy icon indicating copy to clipboard operation
wire-ios_legacy copied to clipboard

pin wire-ios-build-configuration version

Open billypchan opened this issue 4 years ago • 3 comments

What's new in this PR?

Read wire-is version from version.xcconfig. Use the version as an option --branch for download-assets.sh, to download files form wire-ios-build-configuration's tag.

In this PR, the setup script pins the project to https://github.com/wireapp/wire-ios-build-configuration/releases/tag/3.87

When a new pull request is merged into wire-ios-build-configuration, a new tag matching coming release version should be created to match this project's version.

TODO

  • [x] handle the case that the version tag is not exists in wire-ios-build-configuration (use master if the tag not exists.)

billypchan avatar Aug 23 '21 10:08 billypchan

Stale pull request message

github-actions[bot] avatar Oct 26 '21 09:10 github-actions[bot]

@typfel @johnxnguyen this PR is still necessary as we have build older version with older assets.

billypchan avatar Oct 26 '21 09:10 billypchan

Right, I just think would make more sense to add separate build configuration version/tag somewhere and not rely on the Version.xcconfig, because as it is now we would need to create a new build configuration branch for every release when build configuration rarely changes.

Why not add something like: BUILD_CONFIGURATION = "1.0"

And use it fetch build conjuration with that tag. And then when the build configuration changes it's part of the process to update it.

typfel avatar Oct 26 '21 09:10 typfel