wire-ios
wire-ios copied to clipboard
fix: consider apps feature flag for conversation creation - WPB-21441
|
|
Issue
This PR fixes various issues around the conversation creation form (group and channel).
The feature flag apps needs to be considered for showing the "Allow apps" toggle.
Moreover, this PR fixes the following:
The user's type (regular, app, bot) has been introduced recently.
Until then any user having a serviceIdentifier and a providerIdentifier was treated as a bot.
Now that we have ZMUser.type we should only consider this.
A few tests have been adjusted, probably there is still some inconsistency in the codebase.
Testing
Create a new conversation (channel and group)
- in both MLS and Proteus
- as a team and as a personal user
- have the feature flag enabled and disabled
Checklist
- [ ] Title contains a reference JIRA issue number like
[WPB-XXX]. - [ ] Description is filled and free of optional paragraphs.
- [ ] Adds/updates automated tests.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
- [ ] Make sure you use the API for UI elements that support large fonts.
- [ ] All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
- [ ] New UI elements have Accessibility strings for VoiceOver.