wire-ios
wire-ios copied to clipboard
fix: Team members are shown as guests in share logs screen - WPB-18053
|
|
Issue
This PR fixes below issues :
https://wearezeta.atlassian.net/browse/WPB-16584 https://wearezeta.atlassian.net/browse/WPB-11573 https://wearezeta.atlassian.net/browse/WPB-18053
Fix: Improved the logic to detect if the user is guest
We are going to create a new refactoring ticket which includes the centralized logic to show guest status and guest icon. In future we will use the same logic every where. For that francios is going to collect information from confluence pages and create a ticket.
Testing
- Personal users don't see any guest icon
- Personal users can see if users are federated
- Personal users don't see if users are external partners
- As a team member I see other people which are not from my team as guest
Checklist
- [ ] Title contains a reference JIRA issue number like
[WPB-XXX]. - [ ] Description is filled and free of optional paragraphs.
- [ ] Adds/updates automated tests.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
- [ ] Make sure you use the API for UI elements that support large fonts.
- [ ] All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
- [ ] New UI elements have Accessibility strings for VoiceOver.
Test Results
4β282 testsβββ4β255 β ββ6m 41s β±οΈ ββ547 suitesβββββ27 π€ ββββ2 filesββββββββ0 β
Results for commit 2493202d.
:recycle: This comment has been updated with latest results.
LGTM. Is this PR intended to be a draft?
Now it is live