wire-ios icon indicating copy to clipboard operation
wire-ios copied to clipboard

fix: Team members are shown as guests in share logs screen - WPB-18053

Open SyamalaHari opened this issue 1 month ago β€’ 2 comments

BugWPB-18053 [iOS]:Team members are shown as guests in share logs screen

Issue

This PR fixes below issues :

https://wearezeta.atlassian.net/browse/WPB-16584 https://wearezeta.atlassian.net/browse/WPB-11573 https://wearezeta.atlassian.net/browse/WPB-18053

Fix: Improved the logic to detect if the user is guest

We are going to create a new refactoring ticket which includes the centralized logic to show guest status and guest icon. In future we will use the same logic every where. For that francios is going to collect information from confluence pages and create a ticket.

Testing

  1. Personal users don't see any guest icon
  2. Personal users can see if users are federated
  3. Personal users don't see if users are external partners
  4. As a team member I see other people which are not from my team as guest

Checklist

  • [ ] Title contains a reference JIRA issue number like [WPB-XXX].
  • [ ] Description is filled and free of optional paragraphs.
  • [ ] Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • [ ] Make sure you use the API for UI elements that support large fonts.
  • [ ] All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • [ ] New UI elements have Accessibility strings for VoiceOver.

SyamalaHari avatar Oct 20 '25 15:10 SyamalaHari

Test Results

4β€ˆ282 tests   4β€ˆ255 βœ…β€ƒβ€ƒ6m 41s ⏱️ β€‡β€ˆ547 suitesβ€ƒβ€ƒβ€‡β€ˆβ€‡27 πŸ’€ β€‡β€ˆβ€‡β€‡2 filesβ€„β€‚β€ƒβ€ƒβ€‡β€ˆβ€‡β€‡0 ❌

Results for commit 2493202d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 20 '25 15:10 github-actions[bot]

LGTM. Is this PR intended to be a draft?

Now it is live

SyamalaHari avatar Oct 31 '25 08:10 SyamalaHari