wire-ios
wire-ios copied to clipboard
fix: Send invisible messages in a degraded conversation WPB-7402
|
|
Issue
Invisible messages (hidden in the conversation) were not sent in a degraded conversation.
In the MessageDependencyResolver we check if the conversation has degraded and throw an error if so. This is ok for all visible messages because from a UI perspective we are informing the user and asking for confirmation. There is no UI interaction for hidden messages.
Solution
I've added shouldIgnoreTheSecurityLevelCheck to the message and ignore these messages for security check in the MessageDependencyResolver.
Testing
- Degrade mls conversation.
- Receive a message in a group where Read receipts are enabled.
Checklist
- [x] Title contains a reference JIRA issue number like
[WPB-XXX]. - [x] Description is filled and free of optional paragraphs.
- [ ] Adds/updates automated tests.
Test Results
1β168 testsβββ1β168 :white_check_mark:ββ1m 41s :stopwatch: ββ124 suitesββββββ0 :zzz: ββββ1 filesββββββββ0 :x:
Results for commit 8175075a.
:recycle: This comment has been updated with latest results.
Datadog Report
Branch report: fix/message-cannot-be-sent-for-confirmation-WPB-7402
Commit report: 8474364
Test service: wire-ios-mono
:white_check_mark: 0 Failed, 1168 Passed, 0 Skipped, 3.11s Total Time