wire-ios icon indicating copy to clipboard operation
wire-ios copied to clipboard

fix: Send invisible messages in a degraded conversation WPB-7402

Open KaterinaWire opened this issue 1 year ago β€’ 1 comments

BugWPB-7402 [iOS] Message cannot be sent for confirmation and last read messages once conversation is degraded

Issue

Invisible messages (hidden in the conversation) were not sent in a degraded conversation. In the MessageDependencyResolver we check if the conversation has degraded and throw an error if so. This is ok for all visible messages because from a UI perspective we are informing the user and asking for confirmation. There is no UI interaction for hidden messages.

Solution

I've added shouldIgnoreTheSecurityLevelCheck to the message and ignore these messages for security check in the MessageDependencyResolver.

Testing

  1. Degrade mls conversation.
  2. Receive a message in a group where Read receipts are enabled.

Checklist

  • [x] Title contains a reference JIRA issue number like [WPB-XXX].
  • [x] Description is filled and free of optional paragraphs.
  • [ ] Adds/updates automated tests.

KaterinaWire avatar May 15 '24 13:05 KaterinaWire

Test Results

1β€ˆ168 tests   1β€ˆ168 :white_check_mark:  1m 41s :stopwatch: β€‡β€ˆ124 suitesβ€ƒβ€ƒβ€‡β€ˆβ€‡β€‡0 :zzz: β€‡β€ˆβ€‡β€‡1 filesβ€„β€‚β€ƒβ€ƒβ€‡β€ˆβ€‡β€‡0 :x:

Results for commit 8175075a.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 15 '24 13:05 github-actions[bot]

Datadog Report

Branch report: fix/message-cannot-be-sent-for-confirmation-WPB-7402 Commit report: 8474364 Test service: wire-ios-mono

:white_check_mark: 0 Failed, 1168 Passed, 0 Skipped, 3.11s Total Time

datadog-wireapp[bot] avatar May 21 '24 15:05 datadog-wireapp[bot]