wire-ios icon indicating copy to clipboard operation
wire-ios copied to clipboard
verified publisher icon wireapp

refactor: update events api

Open johnxnguyen opened this issue 1 year ago • 1 comments

Issue

Please describe the issue.

Optional: add details about technical approach, solutions etc.

Optional: reference dependencies to other pull requests etc.

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

Checklist

  • [ ] Title contains a reference JIRA issue number like [WPB-XXX].
  • [ ] Description is filled and free of optional paragraphs.
  • [ ] Adds/updates automated tests.

johnxnguyen avatar Apr 18 '24 12:04 johnxnguyen

Nice!

Do have any idea for how to deal with fields which are shared between events? For example I think all conversation events have a conversationID and senderID and a timestamp.

We do perform certain operations on all conversation events, like updating the last modified date.

I suppose if we run into this issue we could create protocols which the event payload conform? Maybe it's non issue at the API level.

typfel avatar Apr 19 '24 06:04 typfel

Closing as this was implemented via other PRs.

johnxnguyen avatar Jun 17 '24 13:06 johnxnguyen