wire-desktop icon indicating copy to clipboard operation
wire-desktop copied to clipboard

flip electron fuses during app build process (FS-997)

Open comawill opened this issue 2 years ago • 0 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Electron Supports fuses for enhanced security (see also https://www.electronjs.org/docs/latest/tutorial/fuses)

Solutions

Flip fuses after the app binary is created.

Testing

How to Test

Each binary for each platform needs to be tested, whether it still runs or not.


PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

comawill avatar Sep 22 '22 16:09 comawill