kalium icon indicating copy to clipboard operation
kalium copied to clipboard

feat: support interactive command on all platforms

Open typfel opened this issue 1 year ago • 2 comments


PR Submission Checklist for internal contributors

  • The PR Title

    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Since mordant 3.0 it supports entering raw mode which means we can move InteractiveCommand into common make it available to all platforms.

In practice this means we can now run the interactive CLI chat client also on the JVM.

Testing

How to Test

./gradlew cli:installDist
cd cli
./cli/build/install/cli/bin/cli login --email <email> --password <password> interactive

PR Post Submission Checklist for internal contributors (Optional)

  • [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

typfel avatar Oct 02 '24 16:10 typfel

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

github-actions[bot] avatar Nov 22 '24 00:11 github-actions[bot]