generic-message-proto icon indicating copy to clipboard operation
generic-message-proto copied to clipboard

Protocol Buffers Version 3 — Investigation

Open bennycode opened this issue 8 years ago • 1 comments

It looks like we are using Protocol Buffers syntax version 2:

  • https://github.com/wireapp/generic-message-proto/blob/master/proto/messages.proto#L1

There is already a Protocol Buffers Version 3 Language Specification, so we might want to update our spec.

@basine, @deanrobertcook & @marcoconti83: Do you see any conflicts in updating to v3?

I guess we might need to change:

// syntax = "proto2";
option java_package = "com.waz.model";

Into:

package com.waz.model;
syntax = "proto3";

bennycode avatar Mar 13 '17 13:03 bennycode

Interesting read regarding backwards compatibility: https://www.ben-morris.com/handling-protocol-buffers-backwards-compatibility-between-versions-2-and-3-using-c/

ffflorian avatar Dec 04 '18 10:12 ffflorian