core-crypto icon indicating copy to clipboard operation
core-crypto copied to clipboard
verified publisher icon wireapp

refactor: fix android linter issue WPB-11527

Open typfel opened this issue 1 year ago • 1 comments

What's new in this PR

By separating the android bindings we can enable android specific optimisations, which include appropriate fallbacks when running on older android version. This removes the linter warnings since API usage is now scoped to the correct android sdk version.

see: https://github.com/mozilla/uniffi-rs/issues/2226

PR Submission Checklist for internal contributors
  • The PR Title
    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

typfel avatar Oct 11 '24 14:10 typfel

🐰 Bencher Report

Branchfix/android-wrapper-WPB-11527
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
Commit add f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		11,225,000.00
Commit add f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		733,750.00
Commit add f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		2,930,300.00
Commit add f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		5,093,900.00
Commit add f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		7,744,500.00
Commit add f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		9,391,300.00
Commit add f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		996,890,000.00
Commit add f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		691,720.00
Commit add f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		78,276,000.00
Commit add f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		214,590,000.00
Commit add f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		425,500,000.00
Commit add f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		683,040,000.00
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		111,350,000.00
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		22,333,000.00
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		39,898,000.00
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		54,359,000.00
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		73,068,000.00
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		87,106,000.00
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
⚠️ NO THRESHOLD		11,075,000.00
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
⚠️ NO THRESHOLD		109,390,000.00
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
⚠️ NO THRESHOLD		28,373,000.00
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
⚠️ NO THRESHOLD		49,707,000.00
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
⚠️ NO THRESHOLD		68,816,000.00
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
⚠️ NO THRESHOLD		88,937,000.00
Commit remove f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		19,053,000.00
Commit remove f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		526,490.00
Commit remove f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		2,155,800.00
Commit remove f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		4,895,900.00
Commit remove f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		9,730,600.00
Commit remove f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		13,660,000.00
Commit remove f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		21,654,000.00
Commit remove f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		128,620,000.00
Commit remove f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		107,750,000.00
Commit remove f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		84,858,000.00
Commit remove f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		63,707,000.00
Commit remove f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		42,751,000.00
Commit update f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		128,220,000.00
Commit update f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		723,320.00
Commit update f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		26,547,000.00
Commit update f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		52,065,000.00
Commit update f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		78,913,000.00
Commit update f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		103,050,000.00
Count KeyPackage/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		3,745,200.00
Count KeyPackage/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		460,020.00
Count KeyPackage/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		849,560.00
Count KeyPackage/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		1,555,000.00
Count KeyPackage/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		2,278,200.00
Count KeyPackage/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		3,021,100.00
Create group/cs1/mem📈 view plot
⚠️ NO THRESHOLD		296,840.00
Decrypt f(msg size)/cs1/mem/10📈 view plot
⚠️ NO THRESHOLD		239,530.00
Decrypt f(msg size)/cs1/mem/10010📈 view plot
⚠️ NO THRESHOLD		301,360.00
Decrypt f(msg size)/cs1/mem/2010📈 view plot
⚠️ NO THRESHOLD		266,540.00
Decrypt f(msg size)/cs1/mem/4010📈 view plot
⚠️ NO THRESHOLD		284,960.00
Decrypt f(msg size)/cs1/mem/6010📈 view plot
⚠️ NO THRESHOLD		287,310.00
Decrypt f(msg size)/cs1/mem/8010📈 view plot
⚠️ NO THRESHOLD		295,610.00
Encrypt f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		1,021,900.00
Encrypt f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		281,430.00
Encrypt f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		430,610.00
Encrypt f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		626,850.00
Encrypt f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		759,810.00
Encrypt f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		893,100.00
Encrypt f(msg size)/cs1/mem/10📈 view plot
⚠️ NO THRESHOLD		1,045,200.00
Encrypt f(msg size)/cs1/mem/10010📈 view plot
⚠️ NO THRESHOLD		1,064,600.00
Encrypt f(msg size)/cs1/mem/2010📈 view plot
⚠️ NO THRESHOLD		989,540.00
Encrypt f(msg size)/cs1/mem/4010📈 view plot
⚠️ NO THRESHOLD		1,114,300.00
Encrypt f(msg size)/cs1/mem/6010📈 view plot
⚠️ NO THRESHOLD		1,019,800.00
Encrypt f(msg size)/cs1/mem/8010📈 view plot
⚠️ NO THRESHOLD		1,052,300.00
Generate KeyPackage f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		194,400,000.00
Generate KeyPackage f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		568,960.00
Generate KeyPackage f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		22,606,000.00
Generate KeyPackage f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		65,542,000.00
Generate KeyPackage f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		108,580,000.00
Generate KeyPackage f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		151,590,000.00
Join from external commit f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		233,700,000.00
Join from external commit f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		1,440,900.00
Join from external commit f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		48,006,000.00
Join from external commit f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		94,620,000.00
Join from external commit f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		141,830,000.00
Join from external commit f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		187,650,000.00
Join from welcome f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD		104,870,000.00
Join from welcome f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD		898,430.00
Join from welcome f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD		21,715,000.00
Join from welcome f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD		42,621,000.00
Join from welcome f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD		63,677,000.00
Join from welcome f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD		84,356,000.00
Mls vs Proteus: add/MLS/mem/1📈 view plot
⚠️ NO THRESHOLD		772,170.00
Mls vs Proteus: add/MLS/mem/101📈 view plot
⚠️ NO THRESHOLD		1,866,600.00
Mls vs Proteus: add/MLS/mem/21📈 view plot
⚠️ NO THRESHOLD		945,730.00
Mls vs Proteus: add/MLS/mem/41📈 view plot
⚠️ NO THRESHOLD		1,209,700.00
Mls vs Proteus: add/MLS/mem/61📈 view plot
⚠️ NO THRESHOLD		1,459,800.00
Mls vs Proteus: add/MLS/mem/81📈 view plot
⚠️ NO THRESHOLD		1,717,400.00
Mls vs Proteus: add/Proteus/mem/1📈 view plot
⚠️ NO THRESHOLD		447,500.00
Mls vs Proteus: add/Proteus/mem/101📈 view plot
⚠️ NO THRESHOLD		35,028,000.00
Mls vs Proteus: add/Proteus/mem/21📈 view plot
⚠️ NO THRESHOLD		7,321,700.00
Mls vs Proteus: add/Proteus/mem/41📈 view plot
⚠️ NO THRESHOLD		14,218,000.00
Mls vs Proteus: add/Proteus/mem/61📈 view plot
⚠️ NO THRESHOLD		21,108,000.00
Mls vs Proteus: add/Proteus/mem/81📈 view plot
⚠️ NO THRESHOLD		27,959,000.00
Mls vs Proteus: encrypt/MLS/mem/1📈 view plot
⚠️ NO THRESHOLD		279,870.00
Mls vs Proteus: encrypt/MLS/mem/101📈 view plot
⚠️ NO THRESHOLD		346,560.00
Mls vs Proteus: encrypt/MLS/mem/21📈 view plot
⚠️ NO THRESHOLD		286,940.00
Mls vs Proteus: encrypt/MLS/mem/41📈 view plot
⚠️ NO THRESHOLD		310,830.00
Mls vs Proteus: encrypt/MLS/mem/61📈 view plot
⚠️ NO THRESHOLD		343,290.00
Mls vs Proteus: encrypt/MLS/mem/81📈 view plot
⚠️ NO THRESHOLD		361,780.00
Mls vs Proteus: encrypt/Proteus/mem/1📈 view plot
⚠️ NO THRESHOLD		197,890.00
Mls vs Proteus: encrypt/Proteus/mem/101📈 view plot
⚠️ NO THRESHOLD		8,399,200.00
Mls vs Proteus: encrypt/Proteus/mem/21📈 view plot
⚠️ NO THRESHOLD		1,843,400.00
Mls vs Proteus: encrypt/Proteus/mem/41📈 view plot
⚠️ NO THRESHOLD		3,569,700.00
Mls vs Proteus: encrypt/Proteus/mem/61📈 view plot
⚠️ NO THRESHOLD		5,226,000.00
Mls vs Proteus: encrypt/Proteus/mem/81📈 view plot
⚠️ NO THRESHOLD		6,814,700.00
Mls vs Proteus: remove/MLS/mem/1📈 view plot
⚠️ NO THRESHOLD		13,845,000.00
Mls vs Proteus: remove/MLS/mem/101📈 view plot
⚠️ NO THRESHOLD		1,813,600.00
Mls vs Proteus: remove/MLS/mem/21📈 view plot
⚠️ NO THRESHOLD		11,473,000.00
Mls vs Proteus: remove/MLS/mem/41📈 view plot
⚠️ NO THRESHOLD		8,993,900.00
Mls vs Proteus: remove/MLS/mem/61📈 view plot
⚠️ NO THRESHOLD		6,610,100.00
Mls vs Proteus: remove/MLS/mem/81📈 view plot
⚠️ NO THRESHOLD		4,150,000.00
Mls vs Proteus: remove/Proteus/mem/1📈 view plot
⚠️ NO THRESHOLD		97,441.00
Mls vs Proteus: remove/Proteus/mem/101📈 view plot
⚠️ NO THRESHOLD		683,950.00
Mls vs Proteus: remove/Proteus/mem/21📈 view plot
⚠️ NO THRESHOLD		216,880.00
Mls vs Proteus: remove/Proteus/mem/41📈 view plot
⚠️ NO THRESHOLD		314,860.00
Mls vs Proteus: remove/Proteus/mem/61📈 view plot
⚠️ NO THRESHOLD		449,650.00
Mls vs Proteus: remove/Proteus/mem/81📈 view plot
⚠️ NO THRESHOLD		531,510.00
Mls vs Proteus: update/MLS/mem/1📈 view plot
⚠️ NO THRESHOLD		715,800.00
Mls vs Proteus: update/MLS/mem/101📈 view plot
⚠️ NO THRESHOLD		13,827,000.00
Mls vs Proteus: update/MLS/mem/21📈 view plot
⚠️ NO THRESHOLD		3,512,900.00
Mls vs Proteus: update/MLS/mem/41📈 view plot
⚠️ NO THRESHOLD		6,162,500.00
Mls vs Proteus: update/MLS/mem/61📈 view plot
⚠️ NO THRESHOLD		8,634,400.00
Mls vs Proteus: update/MLS/mem/81📈 view plot
⚠️ NO THRESHOLD		11,300,000.00
Mls vs Proteus: update/Proteus/mem/1📈 view plot
⚠️ NO THRESHOLD		456,340.00
Mls vs Proteus: update/Proteus/mem/101📈 view plot
⚠️ NO THRESHOLD		35,543,000.00
Mls vs Proteus: update/Proteus/mem/21📈 view plot
⚠️ NO THRESHOLD		7,528,500.00
Mls vs Proteus: update/Proteus/mem/41📈 view plot
⚠️ NO THRESHOLD		14,498,000.00
Mls vs Proteus: update/Proteus/mem/61📈 view plot
⚠️ NO THRESHOLD		21,435,000.00
Mls vs Proteus: update/Proteus/mem/81📈 view plot
⚠️ NO THRESHOLD		28,384,000.00
🐰 View full continuous benchmarking report in Bencher

github-actions[bot] avatar Oct 11 '24 14:10 github-actions[bot]