Adds basic test suite for existing functionality
This PR adds a basic test suite for the existing functionality. Since I'm not too familiar with Livewire, I didn't add any tests using Livewire::test(). I also tried to mostly document the existing behavior without changing too much of the implementation.
There were a few issues I noticed while writing the tests:
- The
executemethod on theSpotlightclass does not check ifgetCommandByIdactually found a command. If it returnsnullthemethod_existscheck will fail with aTypeError. - The
placeholderonSpotlightCommandDependencydoesn't have a default value but also isn't required in the constructor. This effectively makes it mandatory to callsetPlaceholdersince you'd run into an error when callingtoArraybecause the$placeholderproperty has not been initialized yet. - The
setTypemethod on theSpotlightCommandDependencyclass accepts any string, even though it looks like the package only knows how to deal withsearchandinput. Maybe replace it with two separate methods to set the$typetosearchorinput, respectively?
Anyways, let me know what you think!
Thanks @ksassnowski - Really appreciate the time you took to make improvements and write the tests🙌 I'll take a look this weekend or Monday and get back to you! Have a great weekend!
Sorry for the wait @ksassnowski, it's still on my list to review, thanks for your patience 🙏
No worries 🤘
Updates?