Oliver Wipfli

icon location I like to fly hot-air balloons and I enjoy online maps, especially with real-time data.

Results 660 comments of Oliver Wipfli

Wrong WebGL detection with modern Chrome and MapboxGL texts in the warning

#947

Wrong WebGL detection with modern Chrome and MapboxGL texts in the warning

What is you exact browser version and OS?

Remove `bench/gl-stats.js`

https://github.com/maplibre/maplibre-gl-js/blob/f87090b70b8a6fbde1a779c44933ce32bffc5d2c/.circleci/config.yml#L188-L199

Remove `bench/gl-stats.js`

Yes, that's a good idea. Maybe we can run the benchmarks on dedicated hardware as part of the MapLibre GL JS CI...

Extend style swap options with stylePatch side-effect

Do the same ones fail in the browser, i.e., when you open the benchmark page in a browser?

Extend style swap options with stylePatch side-effect

The hillshade loading benchmark works for me. The other three broken ones should be fixed once #1297 is merged...

Extend style swap options with stylePatch side-effect

We moved the debug folder in #1366. Can you merge main and move your debug file too?

Extend style swap options with stylePatch side-effect

Thanks for the review, @HarelM!

Extend style swap options with stylePatch side-effect

And cool that you opened the tracking issue or pull request in the docs repo...

Extend style swap options with stylePatch side-effect

`transformStyle` sounds like a good idea to me. Since it is less opiniated than the current implementation, we should make sure to have some good examples how to use it.