Oliver Wipfli

Results 461 comments of Oliver Wipfli

Searching for `render-test` across the codebase shows something like 30 results (maplibre-gl-js/ folder excluded).

I think it is possible to run the render tests in linux with something like this: ```bash git clone --recurse-submodules -j8 https://github.com/maplibre/maplibre-gl-native.git cd maplibre-gl-native # build stuff cmake . -B...

The following 11 tests fail currently: ``` * failed render-tests/symbol-placement/line-overscaled * failed render-tests/symbol-visibility/visible * failed render-tests/text-variable-anchor/rotated-offset * failed render-tests/text-variable-anchor/all-anchors-tile-map-mode * failed render-tests/icon-text-fit/enlargen-both * failed query-tests/circle-radius/tile-boundary * failed query-tests/fill-features-in/default * failed...

Here are the 5 failing render tests: symbol-placement/line-overscaled: ![image](https://user-images.githubusercontent.com/53421382/177167235-274de941-0b56-4083-b0d8-1c5a77369132.png) symbol-visibility/visible: ![image](https://user-images.githubusercontent.com/53421382/177168344-cf23ab9f-2646-4506-a755-56048232f6fd.png) text-variable-anchor/rotated-offset: ![image](https://user-images.githubusercontent.com/53421382/177167774-6b5a462e-ae54-4156-a787-86321379bf80.png) text-variable-anchor/all-anchors-tile-map-mode: ![image](https://user-images.githubusercontent.com/53421382/177168036-a6cbe75a-f684-4cf4-81eb-e8514bd38a79.png) icon-text-fit/enlargen-both: ![image](https://user-images.githubusercontent.com/53421382/177168152-23397f2a-00ae-458c-8719-3bcf976fc8ce.png)

Ah, beautiful. By reverting the fix of #285, i.e., with ```diff if (maxLineHeight != lineHeight) { shiftY = -blockHeight * verticalAlign - Shaping::yOffset; } else { - shiftY = (-verticalAlign...

At commit cf41e113f9225379bc5d32002a3802b4d2d3ad94, i.e., right before #270, only one test failed. It was `icon-text-fit/enlargen-both`. Full log ``` [INFO] {mbgl-render-tes}[General]: GPU Identifier: Mesa Intel(R) Xe Graphics (TGL GT2) * ignore render-tests/symbol-cross-fade/chinese...

At commit 32ed70c95d734590b3e68cd4595a2806fd13c389, i.e., right after #270 many tests fail. If I then add the fix from #285, the 11 tests fail which currently fail on `main`. I guess this...

At 340f3d6cd (Oct 2021), 71 tests fail icon-text-fit/enlargen-both. That was before the boost update.

There is actually a nice website generated with all the test results. Here is an example with the failing tests from #339: ![image](https://user-images.githubusercontent.com/53421382/177189107-df68c9ea-07da-43e7-9905-0e77199a30a6.png)

Ah interesting... Why tests are ignored I don't know. But have have that in MapLibre GL JS as well...