Oliver Wipfli

Results 461 comments of Oliver Wipfli

I think it would be a good moment to put the magic number 8192 or its new value into a unchangeable global variable or something like that.

Ah so this has en effect on memory usage you are saying @prozessor13?

Can you post the benchmark results? I recently fixed them so maybe you need to merge main first...

Please comment on the apparent difference in test/integration/render/tests/text-pitch-alignment/viewport-text-depthtest/expected.png

@candux have you use one of the native platforms in the past? I would like to be able to update native when the shaders in GL JS change. See https://github.com/maplibre/maplibre-gl-native/pull/315...

Would be great if you could update the render test in a separate pull request. Thanks for catching this.

I can give the benchmarks also a try and post them here...

On a first benchmark run on my laptop, http://0.0.0.0:9966/bench/versions?compare=main#WorkerTransfer seems roughly 10 percent slower. @HarelM is that the one which is always 10 percent slower in the second run?

I merged main, now the benchmarks work again...

I wonder what the implications for native are when we change the shaders...