Eclipse-Markdown-Editor-Plugin icon indicating copy to clipboard operation
Eclipse-Markdown-Editor-Plugin copied to clipboard

hash ('#') in code section interpreted as heading // new release?

Open jludvice opened this issue 8 years ago • 11 comments

Hello guys. Would it be possible to fix this comment line being rendered as headline? markdown-example


heading

# some comment
echo "asdf"
java -jar whatever.jar -Dasdf='abc'

jludvice avatar Nov 14 '16 14:11 jludvice

Plugin version:
Markdown Editor 1.2.0.201501260515 markdown.editor.feature.feature.group Winterwell

jludvice avatar Nov 14 '16 14:11 jludvice

@paulvi I just created duplicate of #67 and #68 didn't I? I'm sorry if I did.

jludvice avatar Nov 14 '16 14:11 jludvice

So was #68 not good fix? @JensPiegsa

paulvi avatar Nov 23 '16 15:11 paulvi

I assume that commit fix 09e763007fa031aff577dddf940228eda1033599 is not present in editor version 1.2.0.201501260515, and I didn't try to compile from source.

jludvice avatar Nov 28 '16 11:11 jludvice

My commit only fixed the according issue in the outline view. I also haven't looked into how a new version is deployed. @winterstein : Any plans on a new release?

JensPiegsa avatar Nov 28 '16 11:11 JensPiegsa

I can do. But look also in #72

paulvi avatar Nov 28 '16 13:11 paulvi

@Paulvi - Please go ahead with a new release if we've got good extra contributions. Thank you for your work in managing the project.

@JensPiegsa - Thank you for contributing!

Apologies for my limited involvement,

  • Daniel

On 28 November 2016 at 13:32, Paul Verest [email protected] wrote:

I can do. But look also in #72 https://github.com/winterstein/Eclipse-Markdown-Editor-Plugin/pull/72

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/winterstein/Eclipse-Markdown-Editor-Plugin/issues/71#issuecomment-263271833, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPmsGM0Uj-LKjL_C8F5QX3a37sMfJGoks5rCtfhgaJpZM4KxX2F .

--

Dr Daniel Winterstein Director Edinburgh +44 (0)772 5172 612 http://sodash.com http://sogrow.co.uk

winterstein avatar Nov 28 '16 21:11 winterstein

I think @grosenberg is close to take over the project

From the History all latest changes were done by not me, but @tbrugz @oliviermartin

History

1.0
1.1 (24 Feb 2014) by Telmo Brugnara @tbrugz #40
Rich color preferences #35 #37
1.2 (Jan 2015) by Olivier Martin @oliviermartin #52
Update preview when the file is saved #48
MultiMarkdown metadata #49
GitHub code blocks #50
detecting links #51
open GFM View from Markdown View #53

paulvi avatar Dec 03 '16 15:12 paulvi

Hello Gerald (@grosenberg) cc Paul (@paulvi)

If you'd like to take over managing the project - provided Paul agrees, that would be OK with me. Regardless of which, thank you for contributing.

Kind regards,

  • Daniel

On 3 December 2016 at 15:17, Paul Verest [email protected] wrote:

I think @grosenberg https://github.com/grosenberg is close to take over the project

From the History all latest changes were done by not me, but @tbrugz https://github.com/tbrugz @oliviermartin https://github.com/oliviermartin

History

1.0 1.1 (24 Feb 2014) by Telmo Brugnara @tbrugz #40 Rich color preferences #35 #37 1.2 (Jan 2015) by Olivier Martin @oliviermartin #52 Update preview when the file is saved #48 MultiMarkdown metadata #49 GitHub code blocks #50 detecting links #51 open GFM View from Markdown View #53

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/winterstein/Eclipse-Markdown-Editor-Plugin/issues/71#issuecomment-264645050, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPmsOAzIYLqgSajjFNZoIxOQIlHQ53Yks5rEYgOgaJpZM4KxX2F .

--

Dr Daniel Winterstein Director Edinburgh +44 (0)772 5172 612 http://sodash.com http://sogrow.co.uk

winterstein avatar Dec 04 '16 10:12 winterstein

I am OK, fork at https://github.com/grosenberg/MarkdownEditor looks well

paulvi avatar Dec 07 '16 14:12 paulvi

I just tried to build plugin from sources and

  • outline view is correct
  • but editor still highlights code comment as heading :(

readme-headlines

jludvice avatar Dec 09 '16 15:12 jludvice