Winter
Winter
I'll make a follow up PR cleaning up the bits I left, and fixing the update script, but the package builds so at least it'll work once it hits unstable....
Something I'm confused about is why these errors seemingly happen inconsistently (see https://github.com/NixOS/nixpkgs/issues/187009 and https://github.com/NixOS/nixpkgs/pull/182189#pullrequestreview-1046678010). Does anyone (@cmoog maybe) have any clue why this is?
Wonder why `ofborg-eval-package-list` never failed with the previous commits (when it should have). Edit, hours later: but it did for the same type of problem just now...?
I don't like that OfBorg added the clean up label, though I don't think it gives specifics as to why. 😕 As far as I know, I fixed every issue...
> As it is now, the unittest hook should be added to `checkInputs` Fixed.
Yes, someone already noted that -- there's a quick fix but also a more proper one that should be upstreamed. See https://matrix.to/#/!kjdutkOsheZdjqYmqp%3Anixos.org/%24_WKyurbQoNXb49piMvNidpULeGz7zFJh-LFM4HoAttE
I made #187778 to fix regressions (drafted until latest eval completes).
Hm, not sure if this is a good idea after thinking about it further. I'll leave it open just in case someone thinks differently.
@adisbladis Yeah, that was my reasoning for reconsidering this change. Strings are much harder to misuse in this case. The main reason this change was proposed in the first place...
~~@kamadorueda Do you mind if I PR a change prototyping what I think this should look like, to further discussion? (I ask since you haven't replied to this.)~~ Ah, the...