Fabricio Duarte
Fabricio Duarte
@blueorangutan package
@IgaoWolf @DaanHoogland PR #6918 adds the support for network-scope settings. After it gets merged, we could also consider adding VPC-scope settings to allow overriding settings such as `site2site.vpn.vpngateway.connection.limit`, `site2site.vpn.service.provider.exclude` and...
> I suggest opening a separate issue and PR to address this behavior, as it's not directly related to the scope of this PR. What do you guys think? (cc....
@blueorangutan package
@blueorangutan package
> clgtm in principal. Did you check if this object is not `toString()`d anywhere else, @winterhazel ? @DaanHoogland yes, its `toString()` is not used anywhere, as its not even implemented....
@DaanHoogland @rohityadavcloud can we run the CI?
Thanks for testing @lucas-a-martins. At first, I think the issue regarding invalid links in the list view should be tackled in another PR, but I'll investigate how it could be...
Hey @lucas-a-martins @DaanHoogland, sorry for the delay. Looking back at this PR, I think it would be better to implement the link validation in both pages by including the volume's...
@lucas-a-martins @DaanHoogland, I changed how the link validation is performed, and included it in the list view as well. Could you guys take another look at this PR?