winter icon indicating copy to clipboard operation
winter copied to clipboard

Add support for uploading SVGs

Open LukeTowers opened this issue 3 years ago • 12 comments

Need to integrate with https://github.com/darylldoyle/svg-sanitizer to automatically sanitize SVGs on upload and then re-add them to the list of allowed defaultExtensions, assetExtensions, and imageExtensions.

Original october#5261

LukeTowers avatar Mar 12 '21 05:03 LukeTowers

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] avatar Jul 21 '21 00:07 github-actions[bot]

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] avatar Sep 20 '21 00:09 github-actions[bot]

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] avatar Nov 20 '21 00:11 github-actions[bot]

Hi Luke, i am too noobish to know if what i found out fits into your request for integrating the sanitizer or if this is a bug that i have encountered. I have allowed the SVG file type inside the cms.php configuration. When i try to upload a SVG file through the Media manager A) i do not get an error B) the file is not listed and uploaded.

So as a workaround i thought: let's upload my 6 SVG files manually via FTP. What happens is A) the files are uploaded B) the Media manager shows me "6 item(s)" to the right of the folder but when i C) enter the folder, no images are shown.

Now when i call the full path of the uploaded SVG, it is shown. In short: the SVG is uploaded and can be used, but the Media manager does not show it.

qroft avatar Jan 19 '22 20:01 qroft

What does your cms.php configuration look like?

LukeTowers avatar Jan 19 '22 22:01 LukeTowers

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] avatar Mar 21 '22 00:03 github-actions[bot]

Hello There

Any update on this?

shadow5og avatar Apr 03 '22 23:04 shadow5og

@shadow5og not at this stage, but you can enable SVG support in the Media Manager now if you wish by configuration change: https://wintertricks.com/tricks/enable-svg-support-in-media-manager

bennothommo avatar Apr 04 '22 00:04 bennothommo

Alright Brother!

shadow5og avatar Apr 04 '22 02:04 shadow5og

This issue will be closed and archived in 3 days, as there has been no activity in this issue for the last 6 months. If this issue is still relevant or you would like to see it actioned, please respond within 3 days. If this issue is critical for your business, please reach out to us at [email protected].

github-actions[bot] avatar Oct 04 '22 00:10 github-actions[bot]

Initial support added in https://github.com/wintercms/storm/pull/61, awaiting further integration with the media library.

LukeTowers avatar Dec 05 '22 19:12 LukeTowers

This issue will be closed and archived in 3 days, as there has been no activity in this issue for the last 6 months. If this issue is still relevant or you would like to see it actioned, please respond within 3 days. If this issue is critical for your business, please reach out to us at [email protected].

github-actions[bot] avatar Jun 06 '23 00:06 github-actions[bot]