winter
winter copied to clipboard
WIP: sends table widget data on each ajax form submit
Instead of sending data of a table widget only on a certain ajax handler (default onSave
) the table widget now sends data on every ajax form submit.
This PR yet does not contain the newly compiled JS files.
This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. If you intend to continue working on this pull request, please respond within 3 days. If this pull request is critical for your business, please reach out to us at [email protected].
@LukeTowers Is this PR still "required" or desired to be merged?
It is, but right now my priorities are on the marketplace. I will circle back to this when I have time.
@der-On @bennothommo what's the status of this PR?
The PR works as described, however, it might be considered a BC break for the table widget behavior since now the table data is included with every AJAX request, not just the specified AJAX event.
I also think it will cause some issues for the Builder plugin, mainly on pages where there are other AJAX actions on the page besides the saving of data.
I'd be inclined to block this PR for the moment until we can ensure that the Builder plugin won't be affected.
@der-On are you interested in testing this change with the builder plugin so that we can move forward with merging it?
@LukeTowers I will try. Please assign it to me, so I do not loose it.