winter icon indicating copy to clipboard operation
winter copied to clipboard

[WIP] 1.2 winter:mirror Enhancements

Open jaxwilko opened this issue 2 years ago • 7 comments

This PR adds support for --copy & --ignore "/pattern/" to the winter:mirror command. These flags allow the mirror command to be used by Laravel Vapor to extract assets during the build stage.

The changes here supersede those made in: https://github.com/wintercms/storm/pull/68 https://github.com/wintercms/winter/pull/430

Originally Vapor only supported 400 assets per project, meaning that we had to use the mirror command to mirror to a disk (remote s3 bucket), however with this update this is no longer required and we therefore don't need the extra functionality, instead we can use copy the files so Vapor can pick them up and ignore development files or files not required for remote deployment.

jaxwilko avatar May 17 '22 15:05 jaxwilko

See also https://github.com/octobercms/october/pull/4227 for some other changes that might be required for this PR to fully work for the purposes of having a working public folder that can be served from

LukeTowers avatar May 17 '22 17:05 LukeTowers

See also octobercms/october#4227 for some other changes that might be required for this PR to fully work for the purposes of having a working public folder that can be served from

This support was added in 0a2778c

jaxwilko avatar May 18 '22 14:05 jaxwilko

This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. If you intend to continue working on this pull request, please respond within 3 days. If this pull request is critical for your business, please reach out to us at [email protected].

github-actions[bot] avatar Jan 14 '23 00:01 github-actions[bot]

This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. If you intend to continue working on this pull request, please respond within 3 days. If this pull request is critical for your business, please reach out to us at [email protected].

github-actions[bot] avatar Jul 18 '23 00:07 github-actions[bot]

@jaxwilko was there anything left to do on this?

LukeTowers avatar Jul 18 '23 05:07 LukeTowers

This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. If you intend to continue working on this pull request, please respond within 3 days. If this pull request is critical for your business, please reach out to us at [email protected].

github-actions[bot] avatar Jan 17 '24 00:01 github-actions[bot]