storm icon indicating copy to clipboard operation
storm copied to clipboard

Added php8.0 features to Resizer

Open jaxwilko opened this issue 3 years ago • 4 comments

A simple PR that adds some php8.0 features and enforces return types.

Something of note, all the widths & heights should probably be ints but in reality they work off floats and changing them to int breaks the tests.

This PR lays groundwork for future improvements.

jaxwilko avatar Mar 18 '22 16:03 jaxwilko

There maybe a bug when trying to resize in crop mode where the calculated values (float) for width & height are passed to crop() and implicitly cast to int resulting in a potential issue.

Need to add more tests for better coverage of the $resizer->setOptions(['mode' => ...]) feature.

jaxwilko avatar Mar 18 '22 16:03 jaxwilko

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this is still being worked on, please respond and we will re-open this pull request. If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] avatar May 18 '22 01:05 github-actions[bot]

@jaxwilko can you remerge develop into this branch and then let me know what's left on it?

LukeTowers avatar Dec 27 '23 22:12 LukeTowers