storm icon indicating copy to clipboard operation
storm copied to clipboard

Initial WIP on improving the File model to use more native disk methods

Open LukeTowers opened this issue 2 years ago • 4 comments

WIP

LukeTowers avatar Feb 21 '23 21:02 LukeTowers

  • Added a constant DISK to the class.
  • Changed fromPost and fromFile methods return type hinting static instead of void, also added nullable types for parameters in both functions.
  • Removed unused setDataAttribute method as it is not used anywhere else in the codebase or called by any other classes/methods etc... 5-6: Fixed typos within comments above each function where 'return' was spelt incorrectly as 'retunr'. This has since been fixed correctly now though :)

what-the-diff[bot] avatar Feb 21 '23 21:02 what-the-diff[bot]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this is still being worked on, please respond and we will re-open this pull request. If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] avatar Jun 25 '24 01:06 github-actions[bot]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this is still being worked on, please respond and we will re-open this pull request. If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions[bot] avatar Aug 25 '24 01:08 github-actions[bot]