docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon wintercms

Document HasRelationships trait methods

Open mjauvin opened this issue 2 years ago • 4 comments

Related: https://github.com/wintercms/storm/pull/46 (specifically: https://github.com/wintercms/storm/commit/b977610d361cc25f24b05062e40a83a6d53680a8) Mention the new addRelation() methods in the model extension docs.

mjauvin avatar Oct 07 '22 13:10 mjauvin

@mjauvin could you add some more headings and links to the ToC to more easily find these sections on the page?

LukeTowers avatar Oct 08 '22 00:10 LukeTowers

Done @LukeTowers

mjauvin avatar Oct 08 '22 03:10 mjauvin

@mjauvin I meant also add the anchor tags and the headings to the page's ToC at the top

LukeTowers avatar Oct 12 '22 16:10 LukeTowers

@LukeTowers from what I can tell, the new format adds this automatically, unless I am mistaken @bennothommo ?

mjauvin avatar Oct 12 '22 17:10 mjauvin

Guys, anything preventing this to be merged?

mjauvin avatar Feb 19 '23 16:02 mjauvin

@mjauvin if you could add type hints to those methods - ie. (string $name, array $config) - I'm happy for you to merge.

bennothommo avatar Feb 20 '23 02:02 bennothommo