gvsbuild icon indicating copy to clipboard operation
gvsbuild copied to clipboard

subprocess.check_call fails with OSError: [Errno 2] No such file or directory

Open calendulish opened this issue 8 years ago • 1 comments

Something is very wrong here: https://github.com/wingtk/gtk-win32/commit/d79696dc7daec7e674569f181bde09d9472bc2f3#diff-2955d5257f635de1df53f55a171ca5c7R1113.

args sometimes is an array (with wget) and sometimes is an str (with cmake), and using "shell=True" check_call will not accept arrays, and vice-versa.

If possible, please don't use shell=True. It'll make the program vulnerable to shell injection.

calendulish avatar Nov 01 '16 08:11 calendulish

Do you feel like making a patch?

nacho avatar Nov 01 '16 19:11 nacho