mindbody-api icon indicating copy to clipboard operation
mindbody-api copied to clipboard

Adding relationship and credit card support

Open BaronWolfenstein opened this issue 12 years ago • 5 comments

These things are nice to have in the models when writing mindbody wrappers.

BaronWolfenstein avatar Aug 31 '13 19:08 BaronWolfenstein

Hi,

Thanks for adding this. I need a few things before merging:

  1. Travis build needs to be green
  2. All new models need specs
  3. Please rebase the commits into a few commits with informative commit messages.

Any questions let me know

wingrunr21 avatar Sep 01 '13 00:09 wingrunr21

ok yeah, only the client has an incomplete spec atm. I'll get on that tonight.

On Sat, Aug 31, 2013 at 5:32 PM, Stafford Brunk [email protected]:

Hi,

Thanks for adding this. I need a few things before merging:

  1. Travis build needs to be green
  2. All new models need specs
  3. Please rebase the commits into a few commits with informative commit messages.

Any questions let me know

— Reply to this email directly or view it on GitHubhttps://github.com/wingrunr21/mindbody-api/pull/3#issuecomment-23616564 .

BaronWolfenstein avatar Sep 01 '13 00:09 BaronWolfenstein

Hmm, I have the client and client relationship models in a sort of circular dependency.

Should I create a related_client model? But that would inherit from client too. I guess the client in client relationship does not need client relationships of its own, just the client tag to be parsed in the xml.

On Sat, Aug 31, 2013 at 5:33 PM, Noah Rahman [email protected] wrote:

ok yeah, only the client has an incomplete spec atm. I'll get on that tonight.

On Sat, Aug 31, 2013 at 5:32 PM, Stafford Brunk [email protected]:

Hi,

Thanks for adding this. I need a few things before merging:

  1. Travis build needs to be green
  2. All new models need specs
  3. Please rebase the commits into a few commits with informative commit messages.

Any questions let me know

— Reply to this email directly or view it on GitHubhttps://github.com/wingrunr21/mindbody-api/pull/3#issuecomment-23616564 .

BaronWolfenstein avatar Sep 01 '13 01:09 BaronWolfenstein

Coverage Status

Changes Unknown when pulling 24380e4bee2f6bcc18bdd3cb63bff336b1dad087 on BaronWolfenstein:master into * on wingrunr21:master*.

coveralls avatar Nov 21 '14 17:11 coveralls

OK, I've been meanig to look into this with regard to their new API changes that just went live

On Fri, Nov 21, 2014 at 11:42 AM, Coveralls [email protected] wrote:

[image: Coverage Status] https://coveralls.io/builds/1509698

Changes Unknown when pulling 24380e4 https://github.com/wingrunr21/mindbody-api/commit/24380e4bee2f6bcc18bdd3cb63bff336b1dad087 on BaronWolfenstein:master into * on wingrunr21:master*.

— Reply to this email directly or view it on GitHub https://github.com/wingrunr21/mindbody-api/pull/3#issuecomment-64008575.

BaronWolfenstein avatar Nov 21 '14 17:11 BaronWolfenstein