gitolite
gitolite copied to clipboard
wingrunr21
support for subdirectory-based multiple keys
Hi, Just as it says on the tin. I need this feature for one of my projects. I'm happy to discuss about any edge cases I may have missed or about any feedback provided.
Lacides
Howdy, Any reason for a Simple SSH key over just using the original SSH key? I think I'd prefer one object (especially since the difference between the two is not clear) that maintains backwards compatibility.
Otherwise, looks solid.
Hey, Sorry for the delay. I really didn't have a particular reason for using a new class, I guess I just thought it'd be easier to write. I'm cool with rewriting it so it uses the original class, though I don't see how the new class breaks backwards compatibility.
Less concerned about the backwards compatibility and more that there are two SSHKey objects without any real distinction. I'd prefer one SSHKey object and if child-objects are needed to properly manage nesting then those can be utilized that way.
I understand. So, I just went and used the original SSHKey class (didn't use a child object) by adding an instance variable to indicate nesting. Let me know what you think.
Hi there!
Any news on this PR? I have pull requests to submit (remove chdir, use last version of Gitlab-grit, etc...), can I send them?
Thank you!
@n-rodriguez I'm not actively maintaining this gem any longer. If this PR seems to do the job I'm ok with merging it.
Go ahead and send other PRs. I'll look them over.