flat-ui-sass icon indicating copy to clipboard operation
flat-ui-sass copied to clipboard

Update converter for Flat UI Pro v1.3.2 and greater

Open wingrunr21 opened this issue 11 years ago • 26 comments

wingrunr21 avatar Aug 25 '14 10:08 wingrunr21

@wingrunr21 just a small line to ask you if you need help with this. I'm not going back to using the official gem so if I can help with the converter upgrade to 1.3.1 pro I'll be glad to.

adamico avatar Nov 08 '14 16:11 adamico

Just need to get some time. I was hoping to tackle it this weekend. There's actually a lot of work to do since bootstrap-sass changed some stuff under the hood as well.

wingrunr21 avatar Nov 08 '14 16:11 wingrunr21

Thanks, if you need a hand I'm here.

adamico avatar Nov 08 '14 20:11 adamico

@wingrunr21 +1 for the conversion!

akshatpradhan avatar Nov 09 '14 01:11 akshatpradhan

any update on this? Ticket was opened 2 months ago

akshatpradhan avatar Nov 15 '14 21:11 akshatpradhan

Working on it. If you feel two months is too long, feel free to submit a PR

wingrunr21 avatar Nov 15 '14 21:11 wingrunr21

wip in 2-2-support branch

wingrunr21 avatar Nov 18 '14 21:11 wingrunr21

great! I'll have a look at it and do some bug report. Thanks @wingrunr21 .

adamico avatar Nov 19 '14 09:11 adamico

@wingrunr21 I checked it out, definitely a WIP but looking good!

akshatpradhan avatar Nov 19 '14 14:11 akshatpradhan

@adamico please don't report bugs on a WIP branch

wingrunr21 avatar Nov 19 '14 16:11 wingrunr21

@wingrunr21 I'll wait until you finish

adamico avatar Nov 19 '14 16:11 adamico

Hello,

Apparently I have the same problem, but no solution for all this time?

I use Flat-UI-Pro-1.3.2 and bootstrap-sass-3.3.3.

Here is the error:

Processing stylesheets... Converting LESS files to Scss: Reading shared mixins from mixins.less /Library/Ruby/Gems/2.0.0/gems/bootstrap-sass-3.3.3/tasks/converter/less_conversion.rb:152:in bootstrap_less_files': undefined methodget_paths_by_type' for #Converter:0x007f99d2082e88 (NoMethodError) from /Library/Ruby/Gems/2.0.0/gems/bootstrap-sass-3.3.3/tasks/converter/less_conversion.rb:54:in shared_mixins' from /Library/Ruby/Gems/2.0.0/gems/bootstrap-sass-3.3.3/tasks/converter/less_conversion.rb:160:inconvert_to_scss' from /Library/Ruby/Gems/2.0.0/gems/bootstrap-sass-3.3.3/tasks/converter/less_conversion.rb:46:in convert_less' from /Library/Ruby/Gems/2.0.0/gems/flat-ui-sass-2.1.3/lib/tasks/converter/flat_ui_less_conversion.rb:31:inblock in process_flat_ui_stylesheet_assets!' from /Library/Ruby/Gems/2.0.0/gems/flat-ui-sass-2.1.3/lib/tasks/converter/flat_ui_less_conversion.rb:26:in each' from /Library/Ruby/Gems/2.0.0/gems/flat-ui-sass-2.1.3/lib/tasks/converter/flat_ui_less_conversion.rb:26:inprocess_flat_ui_stylesheet_assets!' from /Library/Ruby/Gems/2.0.0/gems/flat-ui-sass-2.1.3/lib/tasks/converter.rb:71:in process_flat_ui!' from /Library/Ruby/Gems/2.0.0/gems/flat-ui-sass-2.1.3/lib/flat-ui-sass/cli.rb:10:instart' from /Library/Ruby/Gems/2.0.0/gems/flat-ui-sass-2.1.3/bin/fui_convert:9:in <top (required)>' from /usr/bin/fui_convert:23:inload' from /usr/bin/fui_convert:23:in `

'

Thank you for your help.

jlc75 avatar Mar 02 '15 13:03 jlc75

@jlc75 We switched back to Bootstrap. The Core Dev's of Flat UI don't understand that its not just the aesthetics that's important, but the Developer Experience as well. Having to figure out how to integrate Flat UI into a rails application and maintain it is just too much work.

akshatpradhan avatar Mar 02 '15 15:03 akshatpradhan

@akshatpradhan

Complaining about the Flat UI developer experience here won't get you anywhere. I'm not a core Flat UI dev. I don't even work for Designmodo. I built this project because I wanted a SASS version of Flat UI to use for a client project. It is not supported by Designmodo and I maintain this project on my own accord. I get absolutely nothing from Designmodo for maintaining this.

I pushed my changes up to that branch awhile ago but had other things in my life take priority over finishing. You can see that my Github contribution level has seen a significant decrease over the past few months to correlate this. There's nothing stopping anyone (you included) from finishing the work and submitting a PR. I would ask that instead of making passive-aggressive demands for my unpaid time in this thread, you instead make an attempt to contribute. If you are no longer using this project, please take your negativity elsewhere.

wingrunr21 avatar Mar 02 '15 15:03 wingrunr21

@jlc75 My apologies for being unable to finish upgrading the converter thus far. I have placed a TODO for this week to try and get back into this. There are a couple of things ahead of this on my list, but I'm hopeful I will be able to tackle it soon.

wingrunr21 avatar Mar 02 '15 15:03 wingrunr21

@wingrunr21 my comments weren't directed at you. In fact, I think this project of yours should really be developed by @designmodo because they're the ones makes sales.

Their lack of interest in improving the developer experience has made me switch back to bootstrap and I look forward to someone womping Flat UI with a more aesthetically pleasing AND friendlier developer experience.

akshatpradhan avatar Mar 02 '15 16:03 akshatpradhan

In that, we are in agreement

wingrunr21 avatar Mar 02 '15 16:03 wingrunr21

I understand, damage, good luck.

jlc75 avatar Mar 03 '15 10:03 jlc75

Good luck indeed, looking forward to this.

realadeel avatar Mar 04 '15 08:03 realadeel

Alright everyone, the 2-2-support branch has a preliminarily working converter. I've converted Flat-UI Free with it and there are no Sass errors on page load. There do appear to be a few stylistic bugs I'm still working to fix.

Next steps will be to make sure Pro converts cleanly and then fix incorrectly converted styles.

wingrunr21 avatar Mar 09 '15 16:03 wingrunr21

Pro conversion is in the branch. You must use v1.3.2 or higher as the way the mixins are organized changed in that version.

wingrunr21 avatar Mar 09 '15 18:03 wingrunr21

Very delighted to see this. Thanks for all of your work on this project.

neagle avatar Mar 09 '15 18:03 neagle

Agreed - this is huge and so appreciated.

realadeel avatar Mar 09 '15 18:03 realadeel

:grinning: thanks a ton for your commitment @wingrunr21!

adamico avatar Mar 12 '15 20:03 adamico

Still working on style fixes. As I essentially have to visually compare styles between the demo pages it takes me a bit. :smile:

wingrunr21 avatar Mar 12 '15 20:03 wingrunr21

Don't know if I'm missing something but I seem to have the same issue mentioned on here:

bundle exec fui_convert Convert Flat UI from LESS to SASS type: flat-ui-pro input: C:/Users/Nick/Desktop/flat-ui/flat-ui-sass/flat-ui-pro output: js: vendor/assets/javascripts/flat-ui-pro scss: vendor/assets/stylesheets/flat-ui-pro fonts: vendor/assets/fonts/flat-ui-pro images: vendor/assets/images/flat-ui-pro Processing stylesheets... Converting LESS files to Scss: Reading shared mixins from mixins.less C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/bootstrap-sass-3.3.7/tasks/converter/less_conversion.rb:158:in bootstrap_less_files': undefined method get_paths_by_type' for #Converter:0x00000003fec678 (NoMethodError) from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/bootstrap-sass-3.3.7/tasks/converter/less_conversion.rb:55:in shared_mixins' from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/bootstrap-sass-3.3.7/tasks/converter/less_conversion.rb:164:in convert_to_scss' from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/bootstrap-sass-3.3.7/tasks/converter/less_conversion.rb:47:in convert_less' from C:/Users/Nick/Desktop/flat-ui/flat-ui-sass/lib/tasks/converter/flat_ui_less_conversion.rb:31:in block in process_flat_ui_stylesheet_assets!' from C:/Users/Nick/Desktop/flat-ui/flat-ui-sass/lib/tasks/converter/flat_ui_less_conversion.rb:26:in each' from C:/Users/Nick/Desktop/flat-ui/flat-ui-sass/lib/tasks/converter/flat_ui_less_conversion.rb:26:in process_flat_ui_stylesheet_assets!' from C:/Users/Nick/Desktop/flat-ui/flat-ui-sass/lib/tasks/converter.rb:71:in process_flat_ui!' from C:/Users/Nick/Desktop/flat-ui/flat-ui-sass/lib/flat-ui-sass/cli.rb:10:in start' from C:/Users/Nick/Desktop/flat-ui/flat-ui-sass/bin/fui_convert:9:in <top (required)>' from C:/Ruby23-x64/bin/fui_convert:23:in load' from C:/Ruby23-x64/bin/fui_convert:23:in `

'

Orayi avatar Nov 28 '16 11:11 Orayi