wing icon indicating copy to clipboard operation
wing copied to clipboard

[WIP] feat: cloud.Check (sdk modules written in Wing)

Open Chriscbr opened this issue 1 year ago • 5 comments

WIP - type checking works, but the emitted JS code doesn't work (the compiler doesn't yet know to emit the code for cloud.Check differently than the other SDK modules)

Closes #4810

Checklist

  • [ ] Title matches Winglang's style guide
  • [ ] Description explains motivation and solution
  • [ ] Tests added (always)
  • [ ] Docs updated (only required for features)
  • [ ] Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Chriscbr avatar Jan 05 '24 23:01 Chriscbr

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistence, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @skorfmann
Wing Playground @eladcon

monadabot avatar Jan 05 '24 23:01 monadabot

Console preview environment is available at https://wing-console-pr-5427.fly.dev :rocket:

Last Updated (UTC) 2024-01-06 00:07

monadabot avatar Jan 05 '24 23:01 monadabot

Benchmarks

Comparison to Baseline ⬜
Benchmark Before After Change
version 75ms±2.32 72ms±0.53 -2ms (-3.1%)⬜
jsii_big.test.w -t sim 3340ms±14.04 ... ...
jsii_big.test.w -t tf-aws 3435ms±8.48 ... ...
functions_1.test.w -t sim 614ms±5.51 ... ...
functions_1.test.w -t tf-aws 1837ms±116.31 ... ...
hello_world.test.w -t sim 621ms±5.59 ... ...
hello_world.test.w -t tf-aws 4782ms±35.26 ... ...
functions_10.test.w -t sim 683ms±4.91 ... ...
functions_10.test.w -t tf-aws 4128ms±22.63 ... ...
jsii_small.test.w -t sim 592ms±5.92 ... ...
jsii_small.test.w -t tf-aws 711ms±3.01 ... ...
empty.test.w -t sim 585ms±7.25 ... ...
empty.test.w -t tf-aws 696ms±3.07 ... ...

⬜ Within 1.5 standard deviations 🟩 Faster, Above 1.5 standard deviations 🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 72ms 71ms 73ms 1ms 1ms
jsii_big.test.w -t sim ... ... ... ... ...
jsii_big.test.w -t tf-aws ... ... ... ... ...
functions_1.test.w -t sim ... ... ... ... ...
functions_1.test.w -t tf-aws ... ... ... ... ...
hello_world.test.w -t sim ... ... ... ... ...
hello_world.test.w -t tf-aws ... ... ... ... ...
functions_10.test.w -t sim ... ... ... ... ...
functions_10.test.w -t tf-aws ... ... ... ... ...
jsii_small.test.w -t sim ... ... ... ... ...
jsii_small.test.w -t tf-aws ... ... ... ... ...
empty.test.w -t sim ... ... ... ... ...
empty.test.w -t tf-aws ... ... ... ... ...
Last Updated (UTC) 2024-01-06 00:12

monadabot avatar Jan 06 '24 00:01 monadabot

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. If you need help with the PR, do not hesitate to reach out in the winglang community discord at winglang.discord.com. Feel free to re-open this PR when it is still relevant and ready to be worked on again. Thanks!

github-actions[bot] avatar Feb 05 '24 06:02 github-actions[bot]

@Chriscbr any updates on this? Would be awesome to be able to get this merged :-)

eladb avatar Feb 12 '24 11:02 eladb

🥺

eladb avatar Jun 05 '24 04:06 eladb